fix: fix configuration for fabric view templates#801
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the configuration for fabric view templates by updating export fields, adjusting the available option choices, and updating fallback dependency versions.
- In packages/react-native-builder-bob, the exports configuration is simplified by unconditionally adding the package.json field.
- In packages/create-react-native-library, the Fabric view option is reorganized to remove duplication and improve clarity.
- The fallback Bob version in packages/create-react-native-library and instructions in the FAQ documentation are updated accordingly.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react-native-builder-bob/src/init.ts | Unconditionally adds './package.json' to exports, removing the previous conditional block. |
| packages/create-react-native-library/src/input.ts | Reorders Fabric view option entries to remove duplication. |
| packages/create-react-native-library/src/index.ts | Updates the fallback Bob version from 0.36.0 to 0.38.3. |
| docs/pages/faq.md | Clarifies instructions regarding the package.json export field in package.json. |
Files not reviewed (1)
- packages/create-react-native-library/templates/common/$package.json: Language not supported
Comments suppressed due to low confidence (1)
packages/react-native-builder-bob/src/init.ts:245
- Ensure that adding './package.json' unconditionally to exportsField does not lead to unexpected behavior compared to the previous configuration based on pkg.codegenConfig. If different behavior is needed when codegenConfig is active, consider reintroducing conditional logic or updating related tests.
'./package.json': './package.json',
155adb1 to
bf71823
Compare
atlj
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #788
fabric view
turbo module