feat(crnl): install nitro modules dependency automatically for local modules#828
Merged
feat(crnl): install nitro modules dependency automatically for local modules#828
Conversation
renanmav
reviewed
Apr 22, 2025
renanmav
left a comment
There was a problem hiding this comment.
I haven't tested this manually, but LGTM.
Couple of Qs:
- How can I test this locally?
- Does it install
react-native-nitro-modulesfor both local modules and standalone libraries?
| const appPackageJson: PackageJson = await fs.readJson(appPackageJsonPath); | ||
| const dependencies = appPackageJson['dependencies'] ?? {}; | ||
|
|
||
| dependencies['react-native-nitro-modules'] = config.versions.nitroModules; |
| import fs from 'fs-extra'; | ||
| import path from 'path'; | ||
|
|
||
| export async function determinePackageManager() { |
Collaborator
Author
There was a problem hiding this comment.
We don't officially support bun right now. That being said, there is no real reason libraries bob generates shouldn't work with bun. It might require some changes tho.
Collaborator
Author
That's a yes, |
Member
|
@renanmav dependencies for local libraries have been added to the project's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
create-react-native-librarywill installreact-native-nitro-modulesautomatically for local libraries.Test plan
create-react-native-libraryto your RN appcreate-react-native-libraryin the appNitro Modulesreact-native-nitro-modulesis added to your app's dependencies.