fix(iOS): cleanup the code, split into smaller functions#1014
Merged
okwasniewski merged 1 commit intomasterfrom Jul 31, 2025
Merged
fix(iOS): cleanup the code, split into smaller functions#1014okwasniewski merged 1 commit intomasterfrom
okwasniewski merged 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the iOS implementation of a React Native pager component to improve code organization and maintainability. The main focus is on cleaning up repetitive code patterns and improving logical grouping of methods.
- Extracted event emitter retrieval into a shared helper function
- Added
#pragma markdirectives to organize code into logical sections - Simplified the
scrollViewDidScrollmethod implementation
f73685f to
47511ce
Compare
troZee
approved these changes
Jul 31, 2025
krozniata
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up the code for iOS implementation.
#pragma markfor logic grouping of codescrollViewDidScrollTest Plan
Test if everything works the same
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md