Skip to content

fix(android): remove RTL inversion in PageTransformer to prevent nega… #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MrRefactor wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −4
Draft

fix(android): remove RTL inversion in PageTransformer to prevent nega… #1072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions android/src/main/java/com/reactnativepagerview/PagerViewViewManagerImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,14 +145,17 @@ object PagerViewViewManagerImpl {
fun setPageMargin(host: NestedScrollableHost, margin: Int) {
val pager = getViewPager(host)
val pageMargin = PixelUtil.toPixelFromDIP(margin.toDouble()).toInt()
if (pageMargin == 0) {
pager.setPageTransformer(null)
return
}
/**
* Don't use MarginPageTransformer to be able to support negative margins
* Don't use MarginPageTransformer to be able to support negative margins.
*/
pager.setPageTransformer { page, position ->
val offset = pageMargin * position
if (pager.orientation == ViewPager2.ORIENTATION_HORIZONTAL) {
val isRTL = pager.layoutDirection == View.LAYOUT_DIRECTION_RTL
page.translationX = if (isRTL) -offset else offset
page.translationX = offset
} else {
page.translationY = offset
}
Expand Down Expand Up @@ -184,4 +187,4 @@ object PagerViewViewManagerImpl {
}
Choreographer.getInstance().postFrameCallback(refreshFrameCallback)
}
}
}
Loading