fix: Card components no longer require explicit children prop with ch…#4689
Closed
fredguevs wants to merge 1 commit intocallstack:mainfrom
fredguevs:fix/card-children-props
Closed
fix: Card components no longer require explicit children prop with ch…#4689fredguevs wants to merge 1 commit intocallstack:mainfrom fredguevs:fix/card-children-props
fredguevs wants to merge 1 commit intocallstack:mainfrom
fredguevs:fix/card-children-props
Conversation
|
Hey @fredguevs, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
Member
|
This also means:
These makes this change a breaking change and makes them less flexible. To avoid the issue of passing unnecessary props, it could wrap each item in a context provider instead, tho that's also a breaking change. Also not sure how this PR addresses the type error in the linked issue since these changes are runtime code changes which shouldn't affect typescript errors. |
1062366 to
1da5d15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR addresses an issue where Card components in react-native-paper require an explicit "children" prop even when child views are provided through standard JSX syntax. The current implementation causes problems when non-Card components (like View) are used as direct children, as they receive props they can't handle.
Related issue
Fixes #4684: Card Components require "children" prop despite child views
Test plan
I've tested the changes with the following scenarios:
Reproduction for Issue #4684:
``
``
The fix modifies how the Card component handles children by only passing special props to known Card sub-components (Card.Content, etc,) and leaving other components untouched.