Stricter typing for SegmentedButtons component#4532
Closed
jboteros wants to merge 2 commits intocallstack:mainfrom
Closed
Stricter typing for SegmentedButtons component#4532jboteros wants to merge 2 commits intocallstack:mainfrom
jboteros wants to merge 2 commits intocallstack:mainfrom
Conversation
Related to callstack#4528 Add stricter typing for `onValueChange` in `SegmentedButtons` component to support union types in TypeScript projects. * Modify `src/components/SegmentedButtons/SegmentedButtons.tsx` to accept a generic type parameter for the `value` and `onValueChange` props. * Update `ConditionalValue` type to use the generic type parameter. * Update `Props` type to use the generic type parameter. * Update example files to demonstrate the usage of the stricter typing: * `example/src/Examples/SegmentedButtons/SegmentedButtonDefault.tsx` * `example/src/Examples/SegmentedButtons/SegmentedButtonWithSelectedCheck.tsx` * `example/src/Examples/SegmentedButtons/SegmentedButtonWithDensity.tsx` * `example/src/Examples/SegmentedButtons/SegmentedButtonMultiselect.tsx` * `example/src/Examples/SegmentedButtons/SegmentedButtonMultiselectIcons.tsx` * `example/src/Examples/SegmentedButtons/SegmentedButtonCustomColorCheck.tsx` * `example/src/Examples/SegmentedButtons/SegmentedButtonDisabled.tsx` * `example/src/Examples/SegmentedButtons/SegmentedButtonMultiselectRealCase.tsx` * `example/src/Examples/SegmentedButtons/SegmentedButtonOnlyIcons.tsx` * `example/src/Examples/SegmentedButtons/SegmentedButtonOnlyIconsWithCheck.tsx` * `example/src/Examples/SegmentedButtons/SegmentedButtonRealCase.tsx` * `example/src/Examples/SegmentedButtonsExample.tsx` * `example/src/Examples/ToggleButtonExample.tsx` --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/callstack/react-native-paper/issues/4528?shareId=XXXX-XXXX-XXXX-XXXX).
…cter typing * Remove unnecessary filter function in `filteredData` calculation * Fix ESLint error by updating code formatting
Member
|
Closing in favour of: #4686 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4528
Add stricter typing for
onValueChangeinSegmentedButtonscomponent to support union types in TypeScript projects.src/components/SegmentedButtons/SegmentedButtons.tsxto accept a generic type parameter for thevalueandonValueChangeprops.ConditionalValuetype to use the generic type parameter.Propstype to use the generic type parameter.example/src/Examples/SegmentedButtons/SegmentedButtonDefault.tsxexample/src/Examples/SegmentedButtons/SegmentedButtonWithSelectedCheck.tsxexample/src/Examples/SegmentedButtons/SegmentedButtonWithDensity.tsxexample/src/Examples/SegmentedButtons/SegmentedButtonMultiselect.tsxexample/src/Examples/SegmentedButtons/SegmentedButtonMultiselectIcons.tsxexample/src/Examples/SegmentedButtons/SegmentedButtonCustomColorCheck.tsxexample/src/Examples/SegmentedButtons/SegmentedButtonDisabled.tsxexample/src/Examples/SegmentedButtons/SegmentedButtonMultiselectRealCase.tsxexample/src/Examples/SegmentedButtons/SegmentedButtonOnlyIcons.tsxexample/src/Examples/SegmentedButtons/SegmentedButtonOnlyIconsWithCheck.tsxexample/src/Examples/SegmentedButtons/SegmentedButtonRealCase.tsxexample/src/Examples/SegmentedButtonsExample.tsxexample/src/Examples/ToggleButtonExample.tsxFor more details, open the Copilot Workspace session.