Conversation
|
The mobile version of example app from this branch is ready! You can see it here. |
adrcotfas
changed the title
This was referenced Apr 15, 2026
Collaborator
|
LGTM! |
adrcotfas
force-pushed
the
@adrcotfas/fix/ripple
branch
from
5a6ec84 to
8492645
Compare
|
Hey @adrcotfas, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
adrcotfas
force-pushed
the
@adrcotfas/fix/ripple
branch
from
8492645 to
decadad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Ripple was not showing on several components like list items.
Order of merging:
Related issue
#4810
Test plan
Open the example app with and without this fix and observe the fact that the ripple now works for the main screen list items and the Touchable example.