self code review

Author: mdjastrzebski

src/event-builder/common.ts

@@ -9,15 +9,15 @@ export function buildTouchEvent() {
   return {
     ...baseSyntheticEvent(),
     nativeEvent: {
-      changedTouches: [] as number[],
+      changedTouches: [] as unknown[],
       identifier: 0,
       locationX: 0,
       locationY: 0,
       pageX: 0,
       pageY: 0,
       target: 0,
       timestamp: Date.now(),
-      touches: [] as number[],
+      touches: [] as unknown[],
     },
     currentTarget: { measure: () => {} },
   };

src/event-builder/types.ts

@@ -9,15 +9,14 @@ import type { Fiber, HostElement } from 'test-renderer';
 
 import { act } from './act';
 import { buildScrollEvent, buildTouchEvent } from './event-builder';
-import type { Point } from './event-builder/types';
 import type { EventHandler } from './event-handler';
 import { getEventHandlerFromProps } from './event-handler';
 import { isElementMounted } from './helpers/component-tree';
 import { isHostScrollView, isHostTextInput } from './helpers/host-component-names';
 import { isPointerEventEnabled } from './helpers/pointer-events';
 import { isEditableTextInput } from './helpers/text-input';
 import { nativeState } from './native-state';
-import type { StringWithAutocomplete } from './types';
+import type { Point, StringWithAutocomplete } from './types';
 
 function isTouchResponder(element: HostElement) {
   return Boolean(element.props.onStartShouldSetResponder) || isHostTextInput(element);
@@ -215,7 +214,7 @@ function mergeEventProps(target: Record<string, unknown>, source: Record<string,
     const sourceValue = source[key];
     const targetValue = target[key];
     if (
-      sourceValue &&
+      sourceValue != null &&
       typeof sourceValue === 'object' &&
       !Array.isArray(sourceValue) &&
       targetValue &&

src/fire-event.ts

@@ -1,6 +1,6 @@
 import type { HostElement } from 'test-renderer';
 
-import type { Point } from './event-builder/types';
+import type { Point } from './types';
 
 /**
  * Simulated native state for unmanaged controls.

src/native-state.ts

@@ -3,6 +3,30 @@ export type RefObject<T> = {
   current: T;
 };
 
+/**
+ * Location of an element.
+ */
+export interface Point {
+  y: number;
+  x: number;
+}
+
+/**
+ * Size of an element.
+ */
+export interface Size {
+  height: number;
+  width: number;
+}
+
+/**
+ * Range of text in a text input.
+ */
+export interface TextRange {
+  start: number;
+  end: number;
+}
+
 // TS autocomplete trick
 // Ref: https://github.com/microsoft/TypeScript/issues/29729#issuecomment-567871939
 export type StringWithAutocomplete<T> = T | (string & {});

src/types.ts

@@ -2,11 +2,11 @@ import { stringify } from 'jest-matcher-utils';
 import type { HostElement } from 'test-renderer';
 
 import { buildScrollEvent } from '../../event-builder';
-import type { Point, Size } from '../../event-builder/types';
 import { ErrorWithStack } from '../../helpers/errors';
 import { isHostScrollView } from '../../helpers/host-component-names';
 import { pick } from '../../helpers/object';
 import { nativeState } from '../../native-state';
+import type { Point, Size } from '../../types';
 import type { UserEventConfig, UserEventInstance } from '../setup';
 import { dispatchEvent, wait } from '../utils';
 import { createScrollSteps, inertialInterpolator, linearInterpolator } from './utils';

src/user-event/scroll/scroll-to.ts

@@ -1,4 +1,4 @@
-import type { Point } from '../../event-builder/types';
+import type { Point } from '../../types';
 
 const DEFAULT_STEPS_COUNT = 5;
 

src/user-event/scroll/utils.ts

@@ -1,4 +1,4 @@
-import type { Size } from '../../event-builder/types';
+import type { Size } from '../../types';
 
 /**
  * Simple function for getting mock the size of given text.