tweaks

Author: mdjastrzebski

src/helpers/__tests__/validate-options.test.ts

@@ -16,7 +16,10 @@ test('does not warn when rest object is empty', () => {
 });
 
 test('warns when unknown option is passed', () => {
-  validateOptions('testFunction', { unknownOption: 'value' }, testFunction);
+  function testFunctionWithCall() {
+    validateOptions('testFunction', { unknownOption: 'value' }, testFunctionWithCall);
+  }
+  testFunctionWithCall();
 
   expect(_console.warn).toHaveBeenCalledTimes(1);
   const warningMessage = jest.mocked(_console.warn).mock.calls[0][0];
@@ -25,11 +28,14 @@ test('warns when unknown option is passed', () => {
 });
 
 test('warns when multiple unknown options are passed', () => {
-  validateOptions(
-    'testFunction',
-    { option1: 'value1', option2: 'value2', option3: 'value3' },
-    testFunction,
-  );
+  function testFunctionWithCall() {
+    validateOptions(
+      'testFunction',
+      { option1: 'value1', option2: 'value2', option3: 'value3' },
+      testFunctionWithCall,
+    );
+  }
+  testFunctionWithCall();
 
   expect(_console.warn).toHaveBeenCalledTimes(1);
   const warningMessage = jest.mocked(_console.warn).mock.calls[0][0];
@@ -41,9 +47,9 @@ test('warns when multiple unknown options are passed', () => {
 
 test('warns with correct function name and includes stack trace', () => {
   function render() {
-    // Test function
+    validateOptions('render', { invalid: true }, render);
   }
-  validateOptions('render', { invalid: true }, render);
+  render();
 
   expect(_console.warn).toHaveBeenCalledTimes(1);
   const warningMessage = jest.mocked(_console.warn).mock.calls[0][0];

src/helpers/validate-options.ts

@@ -7,21 +7,23 @@ import { logger } from './logger';
  *
  * @param functionName - The name of the function being called (for error messages)
  * @param restOptions - The rest object from destructuring that contains unknown options
- * @param _callsite - The function where the validation is called from (unused, kept for API compatibility)
+ * @param callsite - The function where the validation is called from (e.g., render, renderHook)
  */
 export function validateOptions(
   functionName: string,
   restOptions: Record<string, unknown>,
   // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
-  _callsite: Function,
+  callsite: Function,
 ): void {
   const unknownKeys = Object.keys(restOptions);
   if (unknownKeys.length > 0) {
-    // Pass validateOptions as callsite so the stack trace shows where the function (e.g., render) was called from
-    const stackTraceError = new ErrorWithStack('STACK_TRACE_ERROR', validateOptions);
-    const stackTrace = stackTraceError.stack
-      ? `\n\n${stackTraceError.stack.split('\n').slice(1).join('\n')}`
-      : '';
+    // Pass the callsite function (e.g., render) to remove it from stack
+    // This leaves only where the user called the function from (e.g., test file)
+    const stackTraceError = new ErrorWithStack('STACK_TRACE_ERROR', callsite);
+    const stackLines = stackTraceError.stack ? stackTraceError.stack.split('\n') : [];
+    // Skip the first line (Error: STACK_TRACE_ERROR) to show the actual call sites
+    // The remaining lines show where the user called the function from
+    const stackTrace = stackLines.length > 1 ? `\n\n${stackLines.slice(1).join('\n')}` : '';
     logger.warn(
       `Unknown option(s) passed to ${functionName}: ${unknownKeys.join(', ')}${stackTrace}`,
     );