fix: check for pointerEvents in both props and styles#1799
Merged
mdjastrzebski merged 1 commit intocallstack:mainfrom Jul 22, 2025
Merged
fix: check for pointerEvents in both props and styles#1799mdjastrzebski merged 1 commit intocallstack:mainfrom
pointerEvents in both props and styles#1799mdjastrzebski merged 1 commit intocallstack:mainfrom
Conversation
### Summary This allows users to test components that use `pointerEvents` in styles instead of props. Required for react-navigation/react-navigation#12693 ### Test plan Related tests were copied and modified so`pointerEvents` is specified in `style` instead of props.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1799 +/- ##
==========================================
- Coverage 95.38% 95.25% -0.14%
==========================================
Files 94 94
Lines 5244 5247 +3
Branches 892 569 -323
==========================================
- Hits 5002 4998 -4
- Misses 242 249 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdjastrzebski
approved these changes
Jul 22, 2025
Member
mdjastrzebski
left a comment
mdjastrzebski
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the PR!
satya164
pushed a commit
to react-navigation/react-navigation
that referenced
this pull request
Aug 2, 2025
BREAKING CHANGE: the minimum required version for `react-native-web` is now `~0.21.0` **Motivation** By replacing usages of `pointerEvents` to use styles instead of props, we won't get an annoying warning in the logs. The underlying issue in React Native Web which prevented children of a `pointer-events: box-none` element from receiving pointer events is resolved by necolas/react-native-web#2789. A follow-up fix to React Native Testing Library was also required, PR here callstack/react-native-testing-library#1799. Fixes #12441 **Test plan** CI (unit + E2E)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This allows users to test components that use
pointerEventsin styles instead of props. Required for react-navigation/react-navigation#12693Test plan
Related tests were copied and modified so
pointerEventsis specified instyleinstead of props.