Skip to content

Commit 3748b41

Browse files
authored
fix: hide persistent cache behind flag (#1151)
* fix: hide persistent cache behind flag * refactor: use env key * chore: changeset
1 parent fc87b9a commit 3748b41

3 files changed

Lines changed: 24 additions & 7 deletions

File tree

.changeset/sharp-socks-dress.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@callstack/repack": patch
3+
---
4+
5+
Hide persistent cache behind `REPACK_EXPERIMENTAL_CACHE` flag

packages/repack/src/commands/common/config/getCommandConfig.ts

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,24 @@
1+
import { EXPERIMENTAL_CACHE_ENV_KEY } from '../../../env.js';
12
import { DEFAULT_HOSTNAME, DEFAULT_PORT } from '../../consts.js';
23

4+
function isExperimentalCacheEnabled() {
5+
return (
6+
process.env[EXPERIMENTAL_CACHE_ENV_KEY] === 'true' ||
7+
process.env[EXPERIMENTAL_CACHE_ENV_KEY] === '1'
8+
);
9+
}
10+
311
function getCacheConfig(bundler: 'rspack' | 'webpack') {
4-
if (bundler === 'rspack') {
5-
return {
6-
cache: true,
7-
experiments: { cache: { type: 'persistent' } },
8-
};
12+
if (isExperimentalCacheEnabled()) {
13+
if (bundler === 'rspack') {
14+
return {
15+
cache: true,
16+
experiments: { cache: { type: 'persistent' } },
17+
};
18+
}
19+
return { cache: { type: 'filesystem' } };
920
}
10-
11-
return { cache: { type: 'filesystem' } };
21+
return {};
1222
}
1323

1424
function getStartCommandDefaults(bundler: 'rspack' | 'webpack') {

packages/repack/src/env.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,5 @@ export const WORKER_ENV_KEY = 'REPACK_WORKER';
44
export const BUNDLE_FILENAME_ENV_KEY = 'REPACK_BUNDLE_FILENAME';
55
export const SOURCEMAP_FILENAME_ENV_KEY = 'REPACK_SOURCEMAP_FILENAME';
66
export const ASSETS_DEST_ENV_KEY = 'REPACK_ASSETS_DEST';
7+
8+
export const EXPERIMENTAL_CACHE_ENV_KEY = 'REPACK_EXPERIMENTAL_CACHE';

0 commit comments

Comments
 (0)