Skip to content

Commit 7868bdb

Browse files
committed
feat: allow empty return from error hooks
1 parent 9dd81af commit 7868bdb

2 files changed

Lines changed: 11 additions & 6 deletions

File tree

biome.jsonc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@
4848
"suspicious": {
4949
"noControlCharactersInRegex": "off",
5050
"noExplicitAny": "off",
51-
"noFallthroughSwitchClause": "off"
51+
"noFallthroughSwitchClause": "off",
52+
"noConfusingVoidType": "off"
5253
}
5354
},
5455
"ignore": ["templates/*", "tests/metro-compat/**/__tests__/**"]

packages/repack/src/modules/ScriptManager/ScriptManager.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -246,18 +246,22 @@ export class ScriptManager extends EventEmitter {
246246
afterResolve: (
247247
fn: (args: AfterResolveHookOptions) => Promise<AfterResolveHookOptions>
248248
) => this.hookMap.afterResolve.tapPromise('afterResolve', promisify(fn)),
249-
errorResolve: (fn: (args: ErrorResolveHookOptions) => Promise<void>) =>
250-
this.hookMap.errorResolve.tapPromise('errorResolve', promisify(fn)),
249+
errorResolve: (
250+
fn: (
251+
args: ErrorResolveHookOptions
252+
) => Promise<ScriptLocator | undefined | void>
253+
) => this.hookMap.errorResolve.tapPromise('errorResolve', promisify(fn)),
251254
beforeLoad: (
252255
fn: (args: BeforeLoadHookOptions) => Promise<BeforeLoadHookOptions>
253256
) => this.hookMap.beforeLoad.tapPromise('beforeLoad', promisify(fn)),
254-
load: (fn: (args: LoadHookOptions) => Promise<void>) =>
257+
load: (fn: (args: LoadHookOptions) => Promise<boolean>) =>
255258
this.hookMap.load.tapPromise('load', promisify(fn)),
256259
afterLoad: (
257260
fn: (args: AfterLoadHookOptions) => Promise<AfterLoadHookOptions>
258261
) => this.hookMap.afterLoad.tapPromise('afterLoad', promisify(fn)),
259-
errorLoad: (fn: (args: ErrorLoadHookOptions) => Promise<void>) =>
260-
this.hookMap.errorLoad.tapPromise('errorLoad', promisify(fn)),
262+
errorLoad: (
263+
fn: (args: ErrorLoadHookOptions) => Promise<boolean | undefined | void>
264+
) => this.hookMap.errorLoad.tapPromise('errorLoad', promisify(fn)),
261265
};
262266

263267
/**

0 commit comments

Comments
 (0)