Merge remote-tracking branch 'origin/main' into fix/rn-polyfills-as-runtime-modules

Author: jbroma

.changeset/frank-cougars-go.md

@@ -0,0 +1,5 @@
+---
+"@callstack/repack": patch
+---
+
+Handle previous compiler errors and abort bundling in `RepackOutputPlugin`

CLAUDE.md

@@ -4,11 +4,11 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 
 ## Development Commands
 
-This is a pnpm monorepo using Nx for task orchestration. The root package.json contains the most important commands:
+This is a pnpm monorepo using Turborepo for task orchestration. The root package.json contains the most important commands:
 
 **Build & Development:**
-- `pnpm build` - Build all packages using Nx
-- `pnpm dev` - Build once then watch for changes across all packages
+- `pnpm build` - Run a Turborepo build across workspace packages
+- `pnpm dev` - Run Turborepo watch mode for build across workspace packages
 - `pnpm lint` - Run Biome linter with auto-fix
 - `pnpm lint:ci` - Run Biome linter without auto-fix (CI mode)
 - `pnpm typecheck` - Run TypeScript checking across all packages
@@ -70,9 +70,9 @@ Re.Pack provides first-class support for Module Federation for microfrontend arc
 
 ## Key Development Notes
 
-- This is a monorepo managed by pnpm workspaces with Nx orchestration
+- This is a monorepo managed by pnpm workspaces with Turborepo orchestration
 - The project supports both Webpack and Rspack as bundling engines
 - Native modules require building iOS and Android code when making changes
 - Always run `pnpm lint` and `pnpm typecheck` before committing changes
 - Use the tester apps to verify functionality across different React Native configurations
-- When working with native code, run `pnpm clang-format` to ensure consistent formatting
+- When working with native code, run `pnpm clang-format` to ensure consistent formatting

nx.json

@@ -7,15 +7,15 @@
   },
   "scripts": {
     "prepare": "is-in-ci || husky",
-    "build": "nx run-many -t build",
-    "dev": "pnpm run build && nx watch --all -- pnpm run build",
+    "build": "turbo run build",
+    "dev": "turbo watch build",
     "lint": "biome check --write",
     "lint:ci": "biome check",
-    "typecheck": "nx run-many -t typecheck --exclude tests/metro-compat",
-    "test": "nx run-many -t test",
+    "typecheck": "turbo run typecheck",
+    "test": "turbo run test",
     "release": "pnpm build && pnpm lint && pnpm test && pnpm changeset publish",
-    "pods": "nx run-many -t pods",
-    "pods:update": "nx run-many -t pods:update",
+    "pods": "turbo run pods",
+    "pods:update": "turbo run pods:update",
     "website:start": "pnpm --filter website run start",
     "website:build": "pnpm --filter website run export"
   },
@@ -32,7 +32,7 @@
     "@changesets/cli": "^2.29.4",
     "husky": "^9.1.6",
     "is-in-ci": "^1.0.0",
-    "nx": "22.4.1",
+    "turbo": "^2.8.10",
     "typescript": "catalog:"
   }
 }

package.json

@@ -184,6 +184,13 @@ export class OutputPlugin {
     );
 
     compiler.hooks.done.tapPromise('RepackOutputPlugin', async (stats) => {
+      if (stats.hasErrors()) {
+        throw new Error(
+          '[RepackOutputPlugin] Compilation failed:\n' +
+            stats.toString('errors-only')
+        );
+      }
+
       const compilationStats = stats.toJson({
         all: false,
         assets: true,

packages/repack/src/plugins/OutputPlugin/OutputPlugin.ts

@@ -1,13 +1,69 @@
+import fs from 'node:fs/promises';
+import os from 'node:os';
+import path from 'node:path';
 import {
   type EntryNormalized,
   ModuleFilenameHelpers,
   type StatsChunk,
+  rspack,
 } from '@rspack/core';
+import RspackVirtualModulePlugin from 'rspack-plugin-virtual-module';
 import {
   OutputPlugin,
   type OutputPluginConfig,
 } from '../OutputPlugin/index.js';
 
+async function testCompile(code: string, expectThrow?: string) {
+  // Create a temporary directory to write files to.
+  const tempDir = await fs.mkdtemp(
+    path.join(os.tmpdir(), 'output-plugin-test-')
+  );
+
+  // And then run the compiler with the provided code.
+  try {
+    const compiler = rspack({
+      context: tempDir,
+      mode: 'production',
+      devtool: false,
+      entry: 'index.js',
+      output: {
+        filename: 'index.bundle',
+        path: path.join(tempDir, 'out'),
+      },
+      plugins: [
+        new OutputPlugin({
+          context: tempDir,
+          platform: 'ios',
+          output: {},
+        }),
+        new RspackVirtualModulePlugin({
+          'index.js': code,
+        }),
+      ],
+    });
+
+    const promise = new Promise<void>((resolve, reject) =>
+      compiler.run((error, _stats) => {
+        if (error) {
+          reject(error);
+        } else {
+          resolve();
+        }
+      })
+    );
+
+    // Depending on whether we expect an error or not, assert accordingly.
+    if (expectThrow) {
+      await expect(promise).rejects.toThrow(expectThrow);
+    } else {
+      await expect(promise).resolves.not.toThrow();
+    }
+  } finally {
+    // Delete the temporary directory after the test
+    await fs.rm(tempDir, { recursive: true, force: true });
+  }
+}
+
 const makeChunk = ({
   name,
   entry = false,
@@ -204,4 +260,17 @@ describe('OutputPlugin', () => {
       });
     });
   });
+
+  describe('apply', () => {
+    it('should throw an error when compilation has errors', async () => {
+      await testCompile(
+        'const x = {{{',
+        '[RepackOutputPlugin] Compilation failed:'
+      );
+    });
+
+    it('should complete successfully when compilation succeeds', async () => {
+      await testCompile('const x = {};');
+    });
+  });
 });