fix: include path in MF2 remote public path#1114
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 98341ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jbroma
added a commit
that referenced
this pull request
Apr 3, 2025
* fix: include path in remote public path * chore: changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the incorrect URL rebasing when resolving MF2 remotes. Previously we were only replacing the base URL (without path) and this caused a regression when
publicPathof a remote is set to a URL with a path (e.g.http://localhost:8081/ios).Since all MF2 assets are always generated with a flat directory structure (meaning they will all exist next to each other, in the same directory), we can take the last part of the URL (after last '/') and rebase it onto the publicPath of an entrypoint of a remote.
Examples:
noop:///asset.jshttp://localhost:8081/ios/chunk.jshttps://example.com/ios/mf-manfiest.jshttps://example.com/ios/entry.jshttps://example.com/ios/asset.jshttps://example.com/ios/chunk.jsTest plan