Skip to content

[chore] add enums for error messages#1132

Closed
12ya wants to merge 6 commits intocallstack:mainfrom
12ya:feat/error-message-enums
Closed

[chore] add enums for error messages#1132
12ya wants to merge 6 commits intocallstack:mainfrom
12ya:feat/error-message-enums

Conversation

@12ya
Copy link
Copy Markdown

@12ya 12ya commented Apr 27, 2025

Summary

Test plan

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 27, 2025

⚠️ No Changeset found

Latest commit: 7617646

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
repack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 5:35pm

Comment thread packages/repack/ios/CodeSigningErrors.swift Outdated
Comment thread packages/repack/ios/CodeSigningErrors.swift Outdated
12ya and others added 2 commits April 29, 2025 10:13
Co-authored-by: Jakub Romańczyk <lorczyslav@gmail.com>
Co-authored-by: Jakub Romańczyk <lorczyslav@gmail.com>
@jbroma
Copy link
Copy Markdown
Contributor

jbroma commented Apr 30, 2025

Hi @12ya,

what's the rationale behind this change?

@12ya
Copy link
Copy Markdown
Author

12ya commented Apr 30, 2025

Hi @12ya,

what's the rationale behind this change?

hey, @jbroma.
thought it's gonna be good to use enums for messages instead of strings, and easier maintenance in case it gonna get larger

Copy link
Copy Markdown
Contributor

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't compile properly and needs to be fixed - but I'm also not sure this is worth it at this point 🤔

image

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2025

This pull request has been marked as stale because it has been inactive for 30 days. Please update this pull request or it will be automatically closed in 14 days.

@github-actions github-actions Bot added the status:stale Missing feedback or response for prolonged period of time. label Jun 4, 2025
@jbroma
Copy link
Copy Markdown
Contributor

jbroma commented Jun 12, 2025

Closing since the PR went stale

@jbroma jbroma closed this Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:stale Missing feedback or response for prolonged period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants