Skip to content

[chore] add enums for error messages #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
12ya wants to merge 6 commits into from
Closed

[chore] add enums for error messages #1132

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea7700b
[chore] add enums for error messages
12ya Apr 27, 2025
dcf7b50
Update CodeSigningErrors.swift
12ya Apr 29, 2025
45d8146
Update CodeSigningErrors.swift
12ya Apr 29, 2025
95f8c3d
Merge branch 'main' into feat/error-message-enums
12ya Apr 29, 2025
7617646
Merge branch 'main' into feat/error-message-enums
12ya Apr 30, 2025
895e819
Merge branch 'main' into feat/error-message-enums
12ya Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions packages/repack/ios/CodeSigningErrors.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,16 @@ enum CodeSigningError : Int, Error {
case bundleVerificationFailed
}

enum CodeSigningErrorMessage: String {
case tokenNotFound = "The bundle verification failed because no token for the bundle was found."
case tokenInvalid = "The bundle verification failed because the token is invalid."
case tokenDecodingFailed = "The bundle verification failed because the token could not be decoded."
case tokenVerificationFailed = "The bundle verification failed because token verification was unsuccessful. This might mean the token has been tampered with."
case publicKeyNotFound = "The bundle verification failed because PublicKey was not found in the bundle. Make sure you've added the PublicKey to the Info.plist under RepackPublicKey key."
case publicKeyInvalid = "The bundle verification failed because the PublicKey is invalid."
case publicKeyNotFound = "The bundle verification failed because the bundle hash is invalid."
}

extension CodeSigningError: CustomNSError {

public static var errorDomain: String {
Expand All @@ -25,19 +35,19 @@ extension CodeSigningError: CustomNSError {

switch self {
case .tokenNotFound:
failureReason = "The bundle verification failed because no token for the bundle was found."
failureReason = CodeSigningErrorMessage.tokenNotFound
case .tokenInvalid:
failureReason = "The bundle verification failed because the token is invalid."
failureReason = CodeSigningErrorMessage.tokenInvalid
case .tokenDecodingFailed:
failureReason = "The bundle verification failed because the token could not be decoded."
failureReason = CodeSigningErrorMessage.tokenDecodingFailed
case .tokenVerificationFailed:
failureReason = "The bundle verification failed because token verification was unsuccessful. This might mean the token has been tampered with."
failureReason = CodeSigningErrorMessage.tokenVerificationFailed
case .publicKeyNotFound:
failureReason = "The bundle verification failed because PublicKey was not found in the bundle. Make sure you've added the PublicKey to the Info.plist under RepackPublicKey key."
failureReason = CodeSigningErrorMessage.publicKeyNotFound
case .publicKeyInvalid:
failureReason = "The bundle verification failed because the PublicKey is invalid."
failureReason = CodeSigningErrorMessage.publicKeyInvalid
case .bundleVerificationFailed:
failureReason = "The bundle verification failed because the bundle hash is invalid."
failureReason = CodeSigningErrorMessage.publicKeyNotFound
}

return [NSLocalizedFailureReasonErrorKey: failureReason]
Expand Down