Skip to content

fix: check for ESM config instead of try catch#1139

Merged
jbroma merged 3 commits intomainfrom
fix/dont-swallow-config-errors
Apr 30, 2025
Merged

fix: check for ESM config instead of try catch#1139
jbroma merged 3 commits intomainfrom
fix/dont-swallow-config-errors

Conversation

@jbroma
Copy link
Copy Markdown
Contributor

@jbroma jbroma commented Apr 30, 2025

Summary

Prevent swallowing errors originating in project config files by determining whether to use import or require based on config extension and project type (commonjs or module) as a fallback

Test plan

  • - testers work

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
repack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 2:44pm

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 30, 2025

🦋 Changeset detected

Latest commit: 820a95f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@callstack/repack Patch
@callstack/repack-plugin-expo-modules Patch
@callstack/repack-plugin-nativewind Patch
@callstack/repack-plugin-reanimated Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jbroma jbroma merged commit be32944 into main Apr 30, 2025
5 checks passed
@jbroma jbroma deleted the fix/dont-swallow-config-errors branch April 30, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant