fix: enqueue resolvers before ScriptManager init#1156
Merged
Conversation
🦋 Changeset detectedLatest commit: b08977d The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Esemesek
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registerRemoteis a sync hook and previous approach with adding resolvers asynchronously proves very brittle as seen in https://github.com/ZephyrCloudIO/zephyr-repack-exampleThe hook is triggered very early in the runtime, before initialisation of RN Core & ScriptManager. Since there is no reliable way to wait for ScriptManager to be initialised, in ResolverPlugin we now check whether the
ScriptManagerinstance is present in runtime:The queue is an internal runtime mechanism and is not exposed to the user.
Ideally, in the future, we could be replace it by generating a virtual module based on the build config for Module Federation - we know that
registerRemotewill be triggered only by the defined remotes in build config. Runtime calls ofregisterRemotein the userland should not be of any concern since they will happen after initialisation ofScriptManagerTest plan