Skip to content

Commit b8f3aa6

Browse files
authored
chore: setup improvement (#37)
<!-- Please provide enough information so that others can review your pull request. --> <!-- Keep pull requests small and focused on a single change. --> ### Summary - removed redundant commands during setup - removed bootstrap commands in all packages - added pod command to install pods where applicable - updated docs to reflect these changes
1 parent adadf5b commit b8f3aa6

21 files changed

Lines changed: 61 additions & 44 deletions

README.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,13 @@ Each of the mini apps could be deployed and run as a standalone app.
6767
Install dependencies for all apps:
6868

6969
```
70-
yarn bootstrap
70+
yarn
71+
```
72+
73+
[Optional] Install pods where applicable
74+
75+
```
76+
yarn pods
7177
```
7278

7379
### Run

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"run:dashboard:android": "yarn workspace dashboard run android",
2424
"bundle:auth:ios": "yarn workspace auth run bundle:ios",
2525
"bundle:auth:android": "yarn workspace auth run bundle:android",
26-
"bootstrap": "yarn && yarn workspaces foreach run bootstrap",
26+
"pods": "yarn workspaces foreach run pods",
2727
"start": "concurrently -P 'yarn:start:*(!standalone) {1}'",
2828
"typecheck": "yarn workspaces foreach run typecheck",
2929
"lint": "yarn workspaces foreach run lint",

packages/auth/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Each of these options needs to be configured in News mini app. This could be don
2222
Install dependencies for all apps in root directory of this monorepo:
2323

2424
```
25-
yarn bootstrap
25+
yarn
2626
```
2727

2828
### Run

packages/auth/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"start": "react-native webpack-start --port 9003",
1010
"test": "jest",
1111
"lint": "eslint . --ext .js,.jsx,.ts,.tsx",
12-
"bootstrap": "yarn",
1312
"bundle:ios": "react-native webpack-bundle --platform ios --entry-file index.js --dev false",
1413
"bundle:android": "react-native webpack-bundle --platform android --entry-file index.js --dev false"
1514
},

packages/booking/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ This is mini app for booking service. Booking exposes `UpcomingAppointments` scr
77
Install dependencies for all apps in root directory of this monorepo:
88

99
```
10-
yarn bootstrap
10+
yarn
1111
```
1212

1313
### Run

packages/booking/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
"test": "jest",
1111
"lint": "eslint . --ext .js,.jsx,.ts,.tsx",
1212
"typecheck": "tsc",
13-
"bootstrap": "yarn",
1413
"bundle:ios": "react-native webpack-bundle --platform ios --entry-file index.js --dev false",
1514
"bundle:android": "react-native webpack-bundle --platform android --entry-file index.js --dev false"
1615
},

packages/catalog-server/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Since ScriptLocatorResolver is an async function, we could fetch URLs there and
2121
Install dependencies for all apps in root directory of this monorepo:
2222

2323
```
24-
yarn bootstrap
24+
yarn
2525
```
2626

2727
### Run
Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,18 @@
11
{
2-
"name": "catalog-server",
3-
"version": "0.0.1",
4-
"description": "Catalog Server",
5-
"main": "index.js",
6-
"private": true,
7-
"installConfig": {
8-
"hoistingLimits": "workspaces"
9-
},
10-
"scripts": {
11-
"start": "node index.js",
12-
"bootstrap": "yarn"
13-
},
14-
"author": "",
15-
"license": "ISC",
16-
"dependencies": {
17-
"express": "^4.18.2"
18-
}
2+
"name": "catalog-server",
3+
"version": "0.0.1",
4+
"description": "Catalog Server",
5+
"main": "index.js",
6+
"private": true,
7+
"installConfig": {
8+
"hoistingLimits": "workspaces"
9+
},
10+
"scripts": {
11+
"start": "node index.js"
12+
},
13+
"author": "",
14+
"license": "ISC",
15+
"dependencies": {
16+
"express": "^4.18.2"
17+
}
1918
}

packages/dashboard/Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ PLATFORMS
9191
ruby
9292

9393
DEPENDENCIES
94-
cocoapods (~> 1.11, >= 1.11.3)
94+
cocoapods (>= 1.11.3)
9595

9696
RUBY VERSION
9797
ruby 2.7.6p219

packages/dashboard/README.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,13 @@ This is mini app for handling business management flow. Dashboard exposes `MainN
77
Install dependencies for all apps in root directory of this monorepo:
88

99
```
10-
yarn bootstrap
10+
yarn
11+
```
12+
13+
Install pods:
14+
15+
```
16+
yarn pods
1117
```
1218

1319
### Run

0 commit comments

Comments
 (0)