fix: bound iOS simulator focus timeout

Author: thymikee

src/platforms/ios/__tests__/index.test.ts

@@ -24,6 +24,7 @@ import {
   captureSimulatorScreenshotWithFallback,
   resolveSimulatorRunnerScreenshotCandidatePaths,
 } from '../screenshot.ts';
+import { focusIosSimulatorWindow } from '../simulator.ts';
 import type { DeviceInfo } from '../../../utils/device.ts';
 import { withDiagnosticsScope } from '../../../utils/diagnostics.ts';
 import { AppError } from '../../../utils/errors.ts';
@@ -260,6 +261,31 @@ test('captureSimulatorScreenshotWithFallback emits fallback diagnostic before us
   }
 });
 
+test('focusIosSimulatorWindow times out instead of hanging indefinitely', async () => {
+  const tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), 'agent-device-ios-focus-timeout-test-'));
+  const openPath = path.join(tmpDir, 'open');
+  await fs.writeFile(openPath, '#!/bin/sh\nsleep 10\n', 'utf8');
+  await fs.chmod(openPath, 0o755);
+
+  const previousPath = process.env.PATH;
+  process.env.PATH = `${tmpDir}${path.delimiter}${previousPath ?? ''}`;
+
+  try {
+    await assert.rejects(
+      () => focusIosSimulatorWindow(),
+      (error: unknown) => {
+        assert.equal(error instanceof AppError, true);
+        assert.equal((error as AppError).code, 'COMMAND_FAILED');
+        assert.match((error as AppError).message, /open timed out after 5000ms/);
+        return true;
+      },
+    );
+  } finally {
+    process.env.PATH = previousPath;
+    await fs.rm(tmpDir, { recursive: true, force: true });
+  }
+});
+
 async function waitForFileText(filePath: string, attempts = 20): Promise<string> {
   let lastError: unknown;
   for (let attempt = 0; attempt < attempts; attempt += 1) {

src/platforms/ios/config.ts

@@ -25,6 +25,12 @@ export const IOS_DEVICECTL_TIMEOUT_MS = resolveTimeoutMs(
   1_000,
 );
 
+export const IOS_SIMULATOR_FOCUS_TIMEOUT_MS = resolveTimeoutMs(
+  process.env.AGENT_DEVICE_IOS_SIMULATOR_FOCUS_TIMEOUT_MS,
+  5_000,
+  1_000,
+);
+
 export const IOS_SIMULATOR_SCREENSHOT_TIMEOUT_MS = resolveTimeoutMs(
   process.env.AGENT_DEVICE_IOS_SIMULATOR_SCREENSHOT_TIMEOUT_MS,
   20_000,

src/platforms/ios/simulator.ts

@@ -4,7 +4,7 @@ import { runCmd } from '../../utils/exec.ts';
 import { Deadline, retryWithPolicy } from '../../utils/retry.ts';
 import { bootFailureHint, classifyBootFailure } from '../boot-diagnostics.ts';
 
-import { IOS_BOOT_TIMEOUT_MS, IOS_SIMCTL_LIST_TIMEOUT_MS } from './config.ts';
+import { IOS_BOOT_TIMEOUT_MS, IOS_SIMCTL_LIST_TIMEOUT_MS, IOS_SIMULATOR_FOCUS_TIMEOUT_MS } from './config.ts';
 import { buildSimctlArgs, buildSimctlArgsForDevice } from './simctl.ts';
 
 export function ensureSimulator(device: DeviceInfo, command: string): void {
@@ -14,7 +14,10 @@ export function ensureSimulator(device: DeviceInfo, command: string): void {
 }
 
 export async function focusIosSimulatorWindow(): Promise<void> {
-  await runCmd('open', ['-a', 'Simulator'], { allowFailure: true });
+  await runCmd('open', ['-a', 'Simulator'], {
+    allowFailure: true,
+    timeoutMs: IOS_SIMULATOR_FOCUS_TIMEOUT_MS,
+  });
 }
 
 export async function ensureBootedSimulator(device: DeviceInfo): Promise<void> {