Skip to content

Commit 8f7375f

Browse files
authored
ci: remove redundant Linux validation and fix unit hang (#411)
* ci: remove redundant linux validation job * test: add bridge scope to packaged metro smoke
1 parent f3a9632 commit 8f7375f

2 files changed

Lines changed: 15 additions & 18 deletions

File tree

.github/workflows/linux.yml

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -14,26 +14,8 @@ concurrency:
1414
cancel-in-progress: true
1515

1616
jobs:
17-
validate:
18-
name: Typecheck & Unit Tests
19-
runs-on: ubuntu-latest
20-
timeout-minutes: 20
21-
steps:
22-
- name: Checkout
23-
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
24-
25-
- name: Setup toolchain
26-
uses: ./.github/actions/setup-node-pnpm
27-
28-
- name: Typecheck
29-
run: pnpm typecheck
30-
31-
- name: Unit tests
32-
run: pnpm test:unit
33-
3417
smoke-linux:
3518
name: Smoke Tests
36-
needs: validate
3719
runs-on: ubuntu-latest
3820
timeout-minutes: 30
3921
env:

test/scripts/metro-prepare-packaged-smoke.mjs

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,11 @@ async function main() {
168168
const configDir = path.join(root, 'config');
169169
const packRoot = path.join(root, 'pack');
170170
const installRoot = path.join(root, 'install');
171+
const bridgeScope = {
172+
tenant: 'tenant-1',
173+
runId: 'run-1',
174+
leaseId: 'lease-1',
175+
};
171176
fs.mkdirSync(projectRoot, { recursive: true });
172177
fs.mkdirSync(configDir, { recursive: true });
173178
fs.mkdirSync(packRoot, { recursive: true });
@@ -332,6 +337,7 @@ async function main() {
332337
metroPublicBaseUrl: 'https://public.example.test',
333338
metroProxyBaseUrl: `http://127.0.0.1:${hostPort}`,
334339
metroBearerToken: 'shared-token',
340+
...bridgeScope,
335341
metroPreparePort: metroPort,
336342
metroStartupTimeoutMs: 30_000,
337343
metroProbeTimeoutMs: 1_000,
@@ -405,11 +411,20 @@ async function main() {
405411
assert.equal(registerCalls > 0, true, 'expected companion registration request');
406412
assert.equal(bridgeCalls >= 2, true, 'expected bridge retry before success');
407413
assert.equal(bridgeSucceeded, true, 'expected bridge success after registration');
414+
assert.equal(registerBody.tenantId, bridgeScope.tenant);
415+
assert.equal(registerBody.runId, bridgeScope.runId);
416+
assert.equal(registerBody.leaseId, bridgeScope.leaseId);
408417
assert.equal(registerBody.local_base_url, `http://127.0.0.1:${metroPort}`);
418+
assert.equal(bridgeBodies[0]?.tenantId, bridgeScope.tenant);
419+
assert.equal(bridgeBodies[0]?.runId, bridgeScope.runId);
420+
assert.equal(bridgeBodies[0]?.leaseId, bridgeScope.leaseId);
409421
assert.equal(
410422
bridgeBodies[0]?.ios_runtime?.metro_bundle_url,
411423
'https://public.example.test/index.bundle?platform=ios&dev=true&minify=false',
412424
);
425+
assert.equal(bridgeBodies.at(-1)?.tenantId, bridgeScope.tenant);
426+
assert.equal(bridgeBodies.at(-1)?.runId, bridgeScope.runId);
427+
assert.equal(bridgeBodies.at(-1)?.leaseId, bridgeScope.leaseId);
413428
assert.equal(
414429
bridgeBodies.at(-1)?.ios_runtime?.metro_bundle_url,
415430
'https://public.example.test/index.bundle?platform=ios&dev=true&minify=false',

0 commit comments

Comments
 (0)