Skip to content

Commit 9e65372

Browse files
authored
fix: resolve test-app dependabot alerts (#649)
* fix: resolve test-app dependabot alerts The postcss/uuid overrides added in #464 stopped applying once test-app ended up nested under the repo-root pnpm-workspace.yaml: pnpm only honors overrides from a workspace root, so test-app's package.json `pnpm.overrides` were silently ignored and the lockfile drifted back to vulnerable versions. Move the overrides into a dedicated examples/test-app/pnpm-workspace.yaml so test-app is its own pnpm root and the overrides are honored, and add scoped overrides for the two remaining alerts: - postcss 8.4.49 -> 8.5.12 (XSS in CSS stringify) - uuid 7.0.3 -> 14.0.0 (missing buffer bounds check) - ws@8 8.20.0 -> 8.21.0 (uninitialized memory disclosure) - brace-expansion@5 5.0.5 -> 5.0.6 (ReDoS / max bypass) ws and brace-expansion overrides are scoped to the vulnerable majors so the non-vulnerable ws@7 / brace-expansion@1 copies in the tree are left untouched. * chore: drop dead lodash-es override, document test-app workspace - Remove the no-op `lodash-es` override from the root package.json (leftover from #368). lodash-es is no longer in the dependency tree, so the override resolved to nothing; regenerating the root lockfile is a no-op. - Add a comment to examples/test-app/pnpm-workspace.yaml explaining why the file exists, so it isn't "tidied away" and the override drift reintroduced.
1 parent 3785a17 commit 9e65372

4 files changed

Lines changed: 37 additions & 29 deletions

File tree

examples/test-app/package.json

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,5 @@
2626
"devDependencies": {
2727
"@types/react": "~19.2.2",
2828
"typescript": "~5.9.2"
29-
},
30-
"pnpm": {
31-
"overrides": {
32-
"@xmldom/xmldom": "0.8.13",
33-
"postcss": "8.5.12",
34-
"uuid": "14.0.0"
35-
}
3629
}
3730
}

examples/test-app/pnpm-lock.yaml

Lines changed: 23 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# This file exists so examples/test-app is treated as its own pnpm workspace
2+
# root. pnpm only honors `overrides` from a workspace root, and because this
3+
# app is nested under the repo-root pnpm-workspace.yaml (without being a member)
4+
# its overrides were silently ignored when declared in package.json, letting the
5+
# lockfile drift back to vulnerable transitive versions (see PR #649). Keeping
6+
# them here ensures they actually apply. These pin transitive deps to versions
7+
# that clear Dependabot security alerts; ws/brace-expansion are scoped to the
8+
# vulnerable major so the non-vulnerable ws@7 / brace-expansion@1 copies stay.
9+
overrides:
10+
'@xmldom/xmldom': 0.8.13
11+
postcss: 8.5.12
12+
uuid: 14.0.0
13+
ws@8: ^8.20.1
14+
brace-expansion@5: ^5.0.6

package.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -163,11 +163,6 @@
163163
"README.md",
164164
"LICENSE"
165165
],
166-
"pnpm": {
167-
"overrides": {
168-
"lodash-es": "4.18.1"
169-
}
170-
},
171166
"keywords": [
172167
"agent",
173168
"device",

0 commit comments

Comments
 (0)