fix: enrich DEVICE_NOT_FOUND error for empty scoped iOS simulator sets#175
Merged
fix: enrich DEVICE_NOT_FOUND error for empty scoped iOS simulator sets#175
Conversation
#168) When selectDevice finds no candidates and a simulatorSetPath context is provided for iOS, throw a detailed error including the set path and a suggested xcrun simctl --set ... create command to provision the first simulator. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
thymikee
force-pushed
the
claude/quizzical-austin
branch
from
08c46dc to
9a02102
Compare
…mulator sets Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #168
Summary
DeviceSelectionContextparameter toselectDevicewith asimulatorSetPathfieldcandidates.length === 0andsimulatorSetPathis set for an iOS (or unspecified) platform, throws an enrichedDEVICE_NOT_FOUNDerror that includes:simulatorSetPathin error details for programmatic accesshintwith a suggestedxcrun simctl --set <path> create ...commanddispatch.tsto passsimulatorSetPaththrough toselectDeviceTest plan
selectDeviceenriches error with set path and hint whensimulatorSetPathcontext is given and no iOS devices foundselectDevicefalls back to generic error when nosimulatorSetPathcontextselectDevicedoes not apply iOS-scoped guidance for Android platform selectorselectDeviceapplies guidance when no platform selector is specified (iOS simulators may be scoped)🤖 Generated with Claude Code