fix: retry alert accept/dismiss on transient 'alert not found' errors#177
Merged
fix: retry alert accept/dismiss on transient 'alert not found' errors#177
Conversation
Adds a 2 s internal retry window for `alert accept` and `alert dismiss` when the runner returns "alert not found" or "no alert". Errors from other causes break the loop immediately and are re-thrown unchanged. Also injects `runnerCommand` as an optional param to enable unit testing without spawning a real runner. Closes #171 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
…issions reference Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alert acceptandalert dismisswhen the runner returnsalert not foundorno alertrunnerCommandas an optional param onhandleSnapshotCommandsfor unit testabilitygetTest plan
snapshot-handler.test.tsFixes #171
🤖 Generated with Claude Code