fix: return deterministic matched-target metadata for find click responses#178
Merged
fix: return deterministic matched-target metadata for find click responses#178
Conversation
…onses (#170) On success, build the response from the matched snapshot node rather than passing through whatever the underlying click/press handler returns. Response now includes: ref, locator, query, and x/y derived from the matched element's rect — all stable across runs. Also makes `dispatch` injectable in `handleFindCommands` (matching the pattern in `handleInteractionCommands`) and adds tests that assert the deterministic shape and verify that non-deterministic platform runner data does not bleed into the response. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
…ences Add response shape documentation for `find "<query>" click --json` to: - website/docs/docs/selectors.md (new "Response shape (click)" section) - skills/agent-device/SKILL.md (guardrail note) - skills/agent-device/references/snapshot-refs.md (new "find click response" section) Follows the fix in #178 that made the response deterministic. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #170.
find "<label>" clickwas passing through the raw response from the underlyingpresshandler, which could include non-deterministic platform runner data (e.g. app-root ref/coordinates from the iOS XCTest runner).ref(matched element),locator(find strategy),query(search term),x/y(center of matched element's rect)locatorandqueryfor better replay observabilityAlso makes
dispatchinjectable inhandleFindCommands(matching the existing pattern inhandleInteractionCommands) to enable unit tests without network calls.Test plan
find.test.tsassert the deterministic response shape forfind clickwith bothanyand explicit locator strategiesnpm test)