Skip to content

fix: support explicit remote daemon endpoints#189

Merged
thymikee merged 3 commits intomainfrom
codex/issue-188-remote-daemon-endpoint
Mar 6, 2026
Merged

fix: support explicit remote daemon endpoints#189
thymikee merged 3 commits intomainfrom
codex/issue-188-remote-daemon-endpoint

Conversation

@thymikee
Copy link
Copy Markdown
Contributor

@thymikee thymikee commented Mar 6, 2026

Summary

Support explicit remote HTTP daemon endpoints via --daemon-base-url / AGENT_DEVICE_DAEMON_BASE_URL and optional auth tokens, so the client skips local daemon discovery/startup and sends JSON-RPC directly to the configured remote daemon.
Add the matching CLI log-tail guard for remote debug mode, parser and transport tests, and docs updates. Touched files: 8. Scope stayed within daemon client/CLI/docs.

Closes #188

Validation

  • pnpm typecheck
  • pnpm test:unit
  • pnpm test:smoke (2 existing loopback-listener tests skipped in this sandbox)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://callstackincubator.github.io/agent-device/pr-preview/pr-189/

Built to branch gh-pages at 2026-03-06 14:30 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d1d2227941

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/daemon-client.ts Outdated
port: url.port,
path: url.pathname + url.search,
method: 'GET',
timeout: 500,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Raise remote health-check timeout beyond localhost default

In remote daemon mode, ensureDaemon gates every command on canConnectHttp, but the probe still uses a hard-coded 500ms timeout that was originally tuned for localhost. On higher-latency links (VPN, cross-region CI runners, busy reverse proxies), /health can exceed 500ms even when /rpc would succeed under the normal request timeout, causing false Remote daemon is unavailable failures before commands are sent.

Useful? React with 👍 / 👎.

@thymikee thymikee merged commit 3bafc24 into main Mar 6, 2026
6 checks passed
@thymikee thymikee deleted the codex/issue-188-remote-daemon-endpoint branch March 6, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support explicit remote HTTP daemon endpoint for agent-device client

1 participant