Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve GitHub security alerts by updating vulnerable npm dependencies and disabling debugging on the Android snapshot helper.
fast-xml-parser, Vite/PostCSS resolution, Rspress/Unhead resolution, and isolated example-app transitive overrides for@xmldom/xmldom,postcss, anduuid.android:debuggable="false"while preservingadb install -tbehavior withandroid:testOnly="true".Touched files: 7. Scope stayed within dependency metadata/lockfiles and the Android snapshot helper manifest/docs.
Validation
pnpm audit --jsonpnpm --dir examples/test-app audit --ignore-workspace --jsonpnpm check:toolingpnpm --dir examples/test-app typecheckpnpm build:android-snapshot-helperaapt2 dump xmltree --file AndroidManifest.xml .tmp/android-snapshot-helper/agent-device-android-snapshot-helper-0.14.0.apk | rg -n "debuggable|testOnly|application"node -e "const { createRequire } = require('node:module'); const req = createRequire(process.cwd() + '/examples/test-app/node_modules/.pnpm/xcode@3.0.1/node_modules/xcode/lib/pbxProject.js'); const uuid = req('uuid'); console.log(typeof uuid.v4, uuid.v4().length)"