Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade SkillGym to v0.6.0 and wire the local benchmark harness into the new suite controls.
schedule: parallelso case/runner pairs can use the SkillGym available-machine parallelism capassert.commands.includes/assert.commands.notIncludeswith structuredcommandMatcher(...)planned command checks for bothagent-device ...and bare command linesassert.output.includesfor positive final-output assertionsTouched files: 5. Scope stayed within SkillGym tooling/docs/tests.
Validation
pnpm formatpnpm check:toolingpnpm typecheckpnpm check:quickpnpm exec skillgym run ./test/skillgym/suites/agent-device-smoke-suite.ts --config ./test/skillgym/skillgym.config.ts --case open-and-snapshot --tag fixture-smoke --runner codex-mini --reporter jsonpnpm exec skillgym run ./test/skillgym/suites/agent-device-smoke-suite.ts --config ./test/skillgym/skillgym.config.ts --case text-replace-uses-fill --tag skill-guidance --runner codex-minipnpm exec skillgym run ./test/skillgym/suites/agent-device-smoke-suite.ts --config ./test/skillgym/skillgym.config.ts --case open-and-snapshot --runner codex-mini --tag fixture-smoke(confirmed defaultParallel 12)pnpm exec skillgym run ./test/skillgym/suites/agent-device-smoke-suite.ts --config ./test/skillgym/skillgym.config.ts --tag fixture-smoke --max-parallel 6(48 runs passed in 3m43s, confirmed out-of-order parallel completion)pnpm exec skillgym run ./test/skillgym/suites/agent-device-smoke-suite.ts --config ./test/skillgym/skillgym.config.ts --tag fixture-smoke(uncapped default reportedParallel 12; 48 runs passed in 2m27s)pnpm test:skillgymran full matrix under previousisolated-by-runnerconfig in 31m48s with 66/70 cases passed and 136/140 runs passed; the 4 failed case/runner pairs all passed when rerun oncegit diff --checkgit diff --check -- AGENTS.mdKnown gap: SkillGym does not currently have a built-in retry-failed option; filed callstackincubator/skillgym#17. Uncapped parallel runs currently emit Node
MaxListenersExceededWarningatParallel 12; noted on the upstream issue.