Boot, reinstall commands, diagnostics overhaul, and review fixes#48
Merged
Conversation
…og env check - Remove redundant findNodeByLocator call in find handler; reuse bestMatches from the ambiguity check instead of scanning nodes twice. - Add IOS_TOOL_MISSING boot failure reason so xcrun/simctl absence gets a specific diagnostic hint instead of generic BOOT_COMMAND_FAILED. - Extract isEnvTruthy helper into retry.ts and replace duplicated RETRY_LOGS_ENABLED parsing in ios/index.ts and android/devices.ts. Co-authored-by: Cursor <cursoragent@cursor.com>
thymikee
force-pushed
the
review/reinstall-followup-fixes
branch
from
85c5d3d to
2aa1bd3
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
bootandreinstallcommands, overhauls boot diagnostics with platform-specific failure reasons, enforcesrunCmdtimeouts, improves find ambiguity handling, enriches replay error context, and replaces CI boot scripting with dogfoodedagent-device boot.Includes review follow-up fixes on top of the original
codex/reinstall-review-followupsbranch:findBestMatchesByLocator; the subsequentfindNodeByLocatorcall (which internally delegates to the same function) was redundant. Now reusesbestMatches.matches[0]directly.IOS_TOOL_MISSINGboot failure reason: whenxcrun/simctlis missing on iOS, the classifier now returnsIOS_TOOL_MISSINGwith a targeted hint ("runxcode-select --install…") instead of the genericBOOT_COMMAND_FAILED.RETRY_LOGS_ENABLEDenv parsing: extractedisEnvTruthy()intoretry.tsand replaced the duplicated inline parsing inios/index.tsandandroid/devices.ts.Test plan
pnpm typecheckpassespnpm test:unit— all 96 tests pass (includes newIOS_TOOL_MISSINGclassification test)pnpm test:smoke— all 5 tests passMade with Cursor