fix: normalize maestro loading ellipsis#648
Merged
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize Unicode ellipsis in Maestro loading text before comparing loading gates, removing the CodeQL identity replacement flagged in security alert 16.
Adds a regression test covering the elapsed
Loading…gate path whenallowAlreadyPastLoadingis enabled.Closes https://github.com/callstackincubator/agent-device/security/code-scanning/16
Validation
Verified with formatting, the focused Maestro runtime assertion test, and the quick lint/typecheck bundle:
pnpm formatpnpm exec vitest run src/compat/maestro/__tests__/runtime-assertions.test.ts --project unitpnpm check:quickTouched-file count: 2. Scope stayed within the Maestro compatibility assertion module and its test.