Skip to content

fix: normalize maestro loading ellipsis#648

Merged
thymikee merged 1 commit into
mainfrom
codex/fix-codeql-identity-replacement
Jun 1, 2026
Merged

fix: normalize maestro loading ellipsis#648
thymikee merged 1 commit into
mainfrom
codex/fix-codeql-identity-replacement

Conversation

@thymikee
Copy link
Copy Markdown
Member

@thymikee thymikee commented Jun 1, 2026

Summary

Normalize Unicode ellipsis in Maestro loading text before comparing loading gates, removing the CodeQL identity replacement flagged in security alert 16.

Adds a regression test covering the elapsed Loading… gate path when allowAlreadyPastLoading is enabled.

Closes https://github.com/callstackincubator/agent-device/security/code-scanning/16

Validation

Verified with formatting, the focused Maestro runtime assertion test, and the quick lint/typecheck bundle:

  • pnpm format
  • pnpm exec vitest run src/compat/maestro/__tests__/runtime-assertions.test.ts --project unit
  • pnpm check:quick

Touched-file count: 2. Scope stayed within the Maestro compatibility assertion module and its test.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

Size Report

Metric Base Current Diff
JS raw 1.1 MB 1.1 MB -18 B
JS gzip 360.9 kB 360.9 kB -12 B
npm tarball 461.7 kB 461.7 kB -11 B
npm unpacked 1.5 MB 1.5 MB -18 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 27.0 ms 27.3 ms +0.3 ms
CLI --help 42.1 ms 42.7 ms +0.6 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/session.js -18 B -12 B

@thymikee thymikee merged commit eb3ca30 into main Jun 1, 2026
18 checks passed
@thymikee thymikee deleted the codex/fix-codeql-identity-replacement branch June 1, 2026 17:09
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-06-01 17:09 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant