-
Notifications
You must be signed in to change notification settings - Fork 130
fix: resolve test-app dependabot alerts #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # This file exists so examples/test-app is treated as its own pnpm workspace | ||
| # root. pnpm only honors `overrides` from a workspace root, and because this | ||
| # app is nested under the repo-root pnpm-workspace.yaml (without being a member) | ||
| # its overrides were silently ignored when declared in package.json, letting the | ||
| # lockfile drift back to vulnerable transitive versions (see PR #649). Keeping | ||
| # them here ensures they actually apply. These pin transitive deps to versions | ||
| # that clear Dependabot security alerts; ws/brace-expansion are scoped to the | ||
| # vulnerable major so the non-vulnerable ws@7 / brace-expansion@1 copies stay. | ||
| overrides: | ||
| '@xmldom/xmldom': 0.8.13 | ||
| postcss: 8.5.12 | ||
| uuid: 14.0.0 | ||
| ws@8: ^8.20.1 | ||
| brace-expansion@5: ^5.0.6 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documented install paths still run
pnpm install --dir examples/test-app --ignore-workspacefrom the root script andpnpm install --ignore-workspaceinexamples/test-app/README.md;--ignore-workspacemakes pnpm behave as if nopnpm-workspace.yamlexists, so these newly moved overrides are not applied on the normal setup path. After a contributor runs the documented install, pnpm can either rewrite the lockfile back without the security overrides or report the lockfile overrides/config as mismatched, which defeats the Dependabot-alert fix this commit is trying to make durable.Useful? React with 👍 / 👎.