fix: preserve profile command limit semantics

Author: piotrski

packages/agent-react-devtools/src/cli.ts

@@ -24,6 +24,10 @@ import { writeFileSync } from 'node:fs';
 import { resolve } from 'node:path';
 import type { IpcCommand } from './types.js';
 
+function getCandidateLimit(limit: number): number {
+  return Math.max(limit, Math.min(60, Math.max(20, limit * 3)));
+}
+
 function usage(): string {
   return `Usage: devtools <command> [options]
 
@@ -377,7 +381,12 @@ async function main(): Promise<void> {
 
     if (cmd0 === 'profile' && cmd1 === 'slow') {
       const limit = parseNumericFlag(flags, 'limit');
-      const resp = await sendCommand({ type: 'profile-slow', limit });
+      const visibleLimit = limit ?? 10;
+      const resp = await sendCommand({
+        type: 'profile-slow',
+        limit,
+        candidateLimit: getCandidateLimit(visibleLimit),
+      });
       if (resp.ok) {
         console.log(formatSlowest(resp.data as any, limit));
       } else {
@@ -389,7 +398,12 @@ async function main(): Promise<void> {
 
     if (cmd0 === 'profile' && cmd1 === 'rerenders') {
       const limit = parseNumericFlag(flags, 'limit');
-      const resp = await sendCommand({ type: 'profile-rerenders', limit });
+      const visibleLimit = limit ?? 10;
+      const resp = await sendCommand({
+        type: 'profile-rerenders',
+        limit,
+        candidateLimit: getCandidateLimit(visibleLimit),
+      });
       if (resp.ok) {
         console.log(formatRerenders(resp.data as any, limit));
       } else {

packages/agent-react-devtools/src/daemon.ts

@@ -13,9 +13,6 @@ const DEFAULT_STATE_DIR = path.join(
 );
 
 let STATE_DIR = DEFAULT_STATE_DIR;
-const PROFILE_READ_CANDIDATE_MULTIPLIER = 3;
-const PROFILE_READ_MIN_CANDIDATES = 20;
-const PROFILE_READ_MAX_CANDIDATES = 60;
 const PROFILE_READ_ENRICH_CONCURRENCY = 5;
 const PROFILE_READ_ENRICH_TIMEOUT_MS = 1000;
 
@@ -98,17 +95,6 @@ async function enrichProfileMetadataOnDemand(
   }));
 }
 
-function getCandidateLimit(limit?: number): number {
-  if (limit === undefined) return PROFILE_READ_MAX_CANDIDATES;
-  return Math.max(
-    limit,
-    Math.min(
-      PROFILE_READ_MAX_CANDIDATES,
-      Math.max(PROFILE_READ_MIN_CANDIDATES, limit * PROFILE_READ_CANDIDATE_MULTIPLIER),
-    ),
-  );
-}
-
 class Daemon {
   private ipcServer: net.Server | null = null;
   private bridge: DevToolsBridge;
@@ -352,18 +338,20 @@ class Daemon {
         }
 
         case 'profile-slow': {
-          const candidateLimit = getCandidateLimit(cmd.limit);
+          const requestedLimit = cmd.limit;
+          const candidateLimit = Math.max(requestedLimit ?? 10, cmd.candidateLimit ?? requestedLimit ?? 10);
           const candidates = this.profiler.getSlowest(this.tree, candidateLimit);
           await enrichProfileMetadataOnDemand(candidates, this.tree, this.bridge, this.profiler);
-          const slowest = this.profiler.getSlowest(this.tree, candidateLimit);
+          const slowest = this.profiler.getSlowest(this.tree, requestedLimit ?? candidateLimit);
           return { ok: true, data: slowest };
         }
 
         case 'profile-rerenders': {
-          const candidateLimit = getCandidateLimit(cmd.limit);
+          const requestedLimit = cmd.limit;
+          const candidateLimit = Math.max(requestedLimit ?? 10, cmd.candidateLimit ?? requestedLimit ?? 10);
           const candidates = this.profiler.getMostRerenders(this.tree, candidateLimit);
           await enrichProfileMetadataOnDemand(candidates, this.tree, this.bridge, this.profiler);
-          const rerenders = this.profiler.getMostRerenders(this.tree, candidateLimit);
+          const rerenders = this.profiler.getMostRerenders(this.tree, requestedLimit ?? candidateLimit);
           return { ok: true, data: rerenders };
         }
 

packages/agent-react-devtools/src/types.ts

@@ -206,8 +206,8 @@ export type IpcCommand =
   | { type: 'profile-start'; name?: string }
   | { type: 'profile-stop' }
   | { type: 'profile-report'; componentId: number | string }
-  | { type: 'profile-slow'; limit?: number }
-  | { type: 'profile-rerenders'; limit?: number }
+  | { type: 'profile-slow'; limit?: number; candidateLimit?: number }
+  | { type: 'profile-rerenders'; limit?: number; candidateLimit?: number }
   | { type: 'profile-timeline'; limit?: number; offset?: number; sort?: 'duration' | 'timeline' }
   | { type: 'profile-commit'; index: number; limit?: number }
   | { type: 'profile-export' }