Skip to content

Commit 5b6b0c4

Browse files
committed
chore: fix typo, adjust docs
1 parent 1585a4a commit 5b6b0c4

2 files changed

Lines changed: 14 additions & 5 deletions

File tree

README.md

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,9 @@ jobs:
7878

7979
When `sign: true` is enabled, this action configures Android code signing by setting Gradle properties. It supports **two property conventions** for maximum compatibility:
8080

81-
### Standard Android Properties
81+
### Android injected properties
82+
83+
(this is an undocumented feature used by Fastlane and AGP)
8284

8385
The action automatically sets `android.injected.signing.*` properties which are natively recognized by the Android Gradle Plugin. These properties work with any standard `build.gradle` configuration without modifications:
8486

@@ -102,13 +104,20 @@ For apps that explicitly read custom properties in their `build.gradle`, the act
102104
signingConfigs {
103105
release {
104106
storeFile file('path/to/keystore.jks')
105-
keyAlias project.findProperty('RNEF_UPLOAD_KEY_ALIAS') ?: 'placeholder'
106-
storePassword project.findProperty('RNEF_UPLOAD_STORE_PASSWORD') ?: 'placeholder'
107-
keyPassword project.findProperty('RNEF_UPLOAD_KEY_PASSWORD') ?: 'placeholder'
107+
keyAlias project.findProperty('ROCK_UPLOAD_KEY_ALIAS') ?: 'placeholder'
108+
storePassword project.findProperty('ROCK_UPLOAD_STORE_PASSWORD') ?: 'placeholder'
109+
keyPassword project.findProperty('ROCK_UPLOAD_KEY_PASSWORD') ?: 'placeholder'
108110
}
109111
}
110112
```
111113

114+
The following mappings are set:
115+
116+
- `ROCK_UPLOAD_KEY_ALIAS``inputs.keystore-key-alias`
117+
- `ROCK_UPLOAD_STORE_FILE``inputs.keystore-store-file`
118+
- `ROCK_UPLOAD_STORE_PASSWORD``inputs.keystore-store-password`
119+
- `ROCK_UPLOAD_KEY_PASSWORD``inputs.keystore-key-password`
120+
112121
Both conventions are set simultaneously, so the action works with any existing build configuration.
113122

114123
## Prerequisites

action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ runs:
191191
echo "android.injected.signing.key.password=${{ inputs.keystore-key-password }}" >> $HOME/.gradle/gradle.properties
192192
193193
# Rock custom properties (for apps that explicitly read them in signingConfigs)
194-
echo "ROCK__UPLOAD_STORE_FILE=${{ inputs.keystore-store-file }}" >> $HOME/.gradle/gradle.properties
194+
echo "ROCK_UPLOAD_STORE_FILE=${{ inputs.keystore-store-file }}" >> $HOME/.gradle/gradle.properties
195195
echo "ROCK_UPLOAD_STORE_PASSWORD=${{ inputs.keystore-store-password }}" >> $HOME/.gradle/gradle.properties
196196
echo "ROCK_UPLOAD_KEY_ALIAS=${{ inputs.keystore-key-alias }}" >> $HOME/.gradle/gradle.properties
197197
echo "ROCK_UPLOAD_KEY_PASSWORD=${{ inputs.keystore-key-password }}" >> $HOME/.gradle/gradle.properties

0 commit comments

Comments
 (0)