fix: make libimobiledevice optional when native crash detection is off

Author: hannojg

packages/platform-ios/src/__tests__/instance.test.ts

@@ -15,6 +15,11 @@ const harnessConfig = {
   metroPort: DEFAULT_METRO_PORT,
 } as HarnessConfig;
 
+const harnessConfigWithoutNativeCrashDetection = {
+  metroPort: DEFAULT_METRO_PORT,
+  detectNativeCrashes: false,
+} as HarnessConfig;
+
 describe('iOS platform instance dependency validation', () => {
   beforeEach(() => {
     vi.restoreAllMocks();
@@ -43,7 +48,7 @@ describe('iOS platform instance dependency validation', () => {
     expect(assertInstalled).not.toHaveBeenCalled();
   });
 
-  it('validates libimobiledevice before creating a physical device instance', async () => {
+  it('validates libimobiledevice before creating a physical device instance when native crash detection is enabled', async () => {
     const assertInstalled = vi
       .spyOn(libimobiledevice, 'assertLibimobiledeviceInstalled')
       .mockRejectedValue(new Error('missing'));
@@ -85,7 +90,7 @@ describe('iOS platform instance dependency validation', () => {
     expect(getSimulatorId).toHaveBeenCalled();
   });
 
-  it('does not try to discover the physical device when the dependency is missing', async () => {
+  it('does not try to discover the physical device when the dependency is missing and native crash detection is enabled', async () => {
     vi.spyOn(libimobiledevice, 'assertLibimobiledeviceInstalled').mockRejectedValue(
       new Error('missing')
     );
@@ -102,4 +107,37 @@ describe('iOS platform instance dependency validation', () => {
     ).rejects.toThrow('missing');
     expect(getDeviceId).not.toHaveBeenCalled();
   });
+
+  it('skips libimobiledevice validation when native crash detection is disabled', async () => {
+    const assertInstalled = vi
+      .spyOn(libimobiledevice, 'assertLibimobiledeviceInstalled')
+      .mockRejectedValue(new Error('missing'));
+    vi.spyOn(devicectl, 'getDevice').mockResolvedValue({
+      identifier: 'physical-device-id',
+      deviceProperties: {
+        name: 'My iPhone',
+        osVersionNumber: '18.0',
+      },
+      hardwareProperties: {
+        marketingName: 'iPhone',
+        productType: 'iPhone17,1',
+        udid: '00008140-001600222422201C',
+      },
+    });
+    vi.spyOn(devicectl, 'isAppInstalled').mockResolvedValue(true);
+
+    const config = {
+      name: 'ios-device',
+      device: { type: 'physical' as const, name: 'My iPhone' },
+      bundleId: 'com.harnessplayground',
+    };
+
+    await expect(
+      getApplePhysicalDevicePlatformInstance(
+        config,
+        harnessConfigWithoutNativeCrashDetection
+      )
+    ).resolves.toBeDefined();
+    expect(assertInstalled).not.toHaveBeenCalled();
+  });
 });

packages/platform-ios/src/instance.ts

@@ -1,4 +1,5 @@
 import {
+  AppMonitor,
   AppNotInstalledError,
   CreateAppMonitorOptions,
   DeviceNotFoundError,
@@ -22,6 +23,14 @@ import {
 } from './app-monitor.js';
 import { assertLibimobiledeviceInstalled } from './libimobiledevice.js';
 
+const createNoopAppMonitor = (): AppMonitor => ({
+  start: async () => {},
+  stop: async () => {},
+  dispose: async () => {},
+  addListener: () => {},
+  removeListener: () => {},
+});
+
 export const getAppleSimulatorPlatformInstance = async (
   config: ApplePlatformConfig,
   harnessConfig: HarnessConfig
@@ -100,7 +109,11 @@ export const getApplePhysicalDevicePlatformInstance = async (
   harnessConfig: HarnessConfig
 ): Promise<HarnessPlatformRunner> => {
   assertAppleDevicePhysical(config.device);
-  await assertLibimobiledeviceInstalled();
+  const detectNativeCrashes = harnessConfig.detectNativeCrashes;
+
+  if (detectNativeCrashes) {
+    await assertLibimobiledeviceInstalled();
+  }
 
   if (harnessConfig.metroPort !== DEFAULT_METRO_PORT) {
     throw new Error(
@@ -153,12 +166,17 @@ export const getApplePhysicalDevicePlatformInstance = async (
     isAppRunning: async () => {
       return await devicectl.isAppRunning(deviceId, config.bundleId);
     },
-    createAppMonitor: (options?: CreateAppMonitorOptions) =>
-      createIosDeviceAppMonitor({
+    createAppMonitor: (options?: CreateAppMonitorOptions) => {
+      if (!detectNativeCrashes) {
+        return createNoopAppMonitor();
+      }
+
+      return createIosDeviceAppMonitor({
         deviceId,
         libimobiledeviceUdid: hardwareUdid,
         bundleId: config.bundleId,
         crashArtifactWriter: options?.crashArtifactWriter,
-      }),
+      });
+    },
   };
 };