fix(runtime): require test context

Author: V3RON

apps/playground/rn-harness.config.mjs

@@ -79,7 +79,7 @@ export default {
     }),
     applePlatform({
       name: 'ios',
-      device: appleSimulator('iPhone 17 Pro', '26.2'),
+      device: appleSimulator('iPhone 17 Pro', '26.4'),
       bundleId: 'com.harnessplayground',
     }),
     applePlatform({

apps/playground/src/__tests__/smoke.harness.ts

@@ -4,4 +4,17 @@ describe('Smoke test', () => {
   test('should run a simple test', () => {
     expect(1 + 1).toBe(2);
   });
+
+  test('should expose task context to tests', (context) => {
+    expect(context).toBeDefined();
+    expect(context.task.type).toBe('test');
+    expect(context.task.mode).toBe('run');
+    expect(context.task.file.name).toBe('src/__tests__/smoke.harness.ts');
+    expect(context.task.suite.name).toBe('Smoke test');
+    expect(context.task.name).toBe('should expose task context to tests');
+  });
+
+  test('should report dynamic skips as skipped', (context) => {
+    context.skip('skip from test context');
+  });
 });

packages/bridge/src/shared/test-collector.ts

@@ -2,7 +2,7 @@ import type { HarnessTestContext } from './test-context.js';
 
 export type TestStatus = 'active' | 'skipped' | 'todo';
 
-export type TestFn = (context?: HarnessTestContext) => void | Promise<void>;
+export type TestFn = (context: HarnessTestContext) => void | Promise<void>;
 
 export type SuiteHookFn = () => void | Promise<void>;
 

packages/coverage-ios/tsconfig.json

@@ -3,6 +3,9 @@
   "files": [],
   "include": [],
   "references": [
+    {
+      "path": "../config"
+    },
     {
       "path": "./tsconfig.lib.json"
     }

packages/coverage-ios/tsconfig.lib.json

@@ -10,5 +10,10 @@
     "types": ["node"],
     "lib": ["DOM", "ES2022"]
   },
-  "include": ["src/**/*.ts"]
+  "include": ["src/**/*.ts"],
+  "references": [
+    {
+      "path": "../config/tsconfig.lib.json"
+    }
+  ]
 }

packages/runtime/src/__tests__/runner-context.test.ts

@@ -15,19 +15,11 @@ vi.mock('../symbolicate.js', async () => {
   };
 });
 
-const getTask = (context?: HarnessTestContext) => {
-  if (!context) {
-    throw new Error('Expected test context to be defined');
-  }
-
+const getTask = (context: HarnessTestContext) => {
   return context.task;
 };
 
-const getTaskContext = (context?: HarnessTestContext) => {
-  if (!context) {
-    throw new Error('Expected test context to be defined');
-  }
-
+const getTaskContext = (context: HarnessTestContext) => {
   return context;
 };
 
@@ -49,15 +41,15 @@ describe('runner task context', () => {
     try {
       const collection = await collector.collect(() => {
         harnessDescribe('Task Context Suite', () => {
-          beforeEach((context: HarnessTestContext | undefined) => {
+          beforeEach((context: HarnessTestContext) => {
             observedTasks.push({ source: 'beforeEach', task: getTask(context) });
           });
 
-          afterEach((context: HarnessTestContext | undefined) => {
+          afterEach((context: HarnessTestContext) => {
             observedTasks.push({ source: 'afterEach', task: getTask(context) });
           });
 
-          harnessIt('exposes task metadata', (context: HarnessTestContext | undefined) => {
+          harnessIt('exposes task metadata', (context: HarnessTestContext) => {
             observedTasks.push({ source: 'test', task: getTask(context) });
           });
         });
@@ -160,7 +152,7 @@ describe('runner task context', () => {
             calls.push('afterEach');
           });
 
-          harnessIt('skips from context', (context: HarnessTestContext | undefined) => {
+          harnessIt('skips from context', (context: HarnessTestContext) => {
             const { skip } = getTaskContext(context);
 
             calls.push('before-skip');
@@ -204,7 +196,7 @@ describe('runner task context', () => {
     try {
       const collection = await collector.collect(() => {
         harnessDescribe('Conditional Skip Suite', () => {
-          harnessIt('continues when condition is false', (context: HarnessTestContext | undefined) => {
+          harnessIt('continues when condition is false', (context: HarnessTestContext) => {
             const { skip } = getTaskContext(context);
 
             calls.push('before');
@@ -240,7 +232,7 @@ describe('runner task context', () => {
             calls.push('afterEach');
           });
 
-          harnessIt('runs finished callbacks', (context: HarnessTestContext | undefined) => {
+          harnessIt('runs finished callbacks', (context: HarnessTestContext) => {
             const { onTestFinished } = getTaskContext(context);
 
             onTestFinished(() => {
@@ -288,7 +280,7 @@ describe('runner task context', () => {
 
           harnessIt(
             'runs finished callback after skip',
-            (context: HarnessTestContext | undefined) => {
+            (context: HarnessTestContext) => {
               const { onTestFinished, skip } = getTaskContext(context);
 
             onTestFinished(() => {
@@ -330,7 +322,7 @@ describe('runner task context', () => {
 
           harnessIt(
             'runs finished callback after failure',
-            (context: HarnessTestContext | undefined) => {
+            (context: HarnessTestContext) => {
               const { onTestFinished } = getTaskContext(context);
 
             onTestFinished(() => {
@@ -370,7 +362,7 @@ describe('runner task context', () => {
             calls.push('afterEach');
           });
 
-          harnessIt('runs failed callbacks', (context: HarnessTestContext | undefined) => {
+          harnessIt('runs failed callbacks', (context: HarnessTestContext) => {
             const { onTestFailed } = getTaskContext(context);
 
             onTestFailed(() => {
@@ -419,7 +411,7 @@ describe('runner task context', () => {
 
           harnessIt(
             'does not run failed callbacks on skip',
-            (context: HarnessTestContext | undefined) => {
+            (context: HarnessTestContext) => {
               const { onTestFailed, skip } = getTaskContext(context);
 
             onTestFailed(() => {
@@ -462,7 +454,7 @@ describe('runner task context', () => {
 
           harnessIt(
             'runs failed callback after afterEach failure',
-            (context: HarnessTestContext | undefined) => {
+            (context: HarnessTestContext) => {
               const { onTestFailed } = getTaskContext(context);
 
             onTestFailed(() => {

packages/runtime/src/collector/types.ts

@@ -5,7 +5,7 @@ import {
   type HarnessTestContext,
 } from '@react-native-harness/bridge';
 
-export type TestFn = (context?: HarnessTestContext) => void | Promise<void>;
+export type TestFn = (context: HarnessTestContext) => void | Promise<void>;
 
 export type SuiteHookFn = () => void | Promise<void>;
 

packages/runtime/src/react-native.d.ts

@@ -17,10 +17,6 @@ declare module 'react-native/Libraries/Core/Devtools/parseErrorStack' {
   export default function parseErrorStack(errorStack?: string): StackFrame[];
 }
 
-declare module 'react-native-url-polyfill' {
-  export const URL: typeof globalThis.URL;
-}
-
 declare module '*.png' {
   import type { ImageSourcePropType } from 'react-native';
 

packages/runtime/src/runner/hooks.ts

@@ -5,9 +5,29 @@ export type HookType = 'beforeEach' | 'afterEach' | 'beforeAll' | 'afterAll';
 
 const collectInheritedHooks = (
   suite: TestSuite,
-  hookType: HookType
-): Array<TestFn | SuiteHookFn> => {
-  const hooks: Array<TestFn | SuiteHookFn> = [];
+  hookType: 'beforeEach' | 'afterEach'
+): TestFn[] => {
+  const hooks: TestFn[] = [];
+  const suiteChain: TestSuite[] = [];
+
+  let current: TestSuite | undefined = suite;
+  while (current) {
+    suiteChain.unshift(current);
+    current = current.parent;
+  }
+
+  for (const currentSuite of suiteChain) {
+    hooks.push(...currentSuite[hookType]);
+  }
+
+  return hooks;
+};
+
+const collectSuiteHooks = (
+  suite: TestSuite,
+  hookType: 'beforeAll' | 'afterAll'
+): SuiteHookFn[] => {
+  const hooks: SuiteHookFn[] = [];
   const suiteChain: TestSuite[] = [];
 
   // Collect all suites from current to root
@@ -17,23 +37,15 @@ const collectInheritedHooks = (
     currentSuite = currentSuite.parent;
   }
 
-  if (hookType === 'beforeEach' || hookType === 'beforeAll') {
-    // For beforeEach/beforeAll: run parent hooks first (reverse the chain)
+  if (hookType === 'beforeAll') {
+    // Run parent suite hooks before child suite hooks.
     for (let i = suiteChain.length - 1; i >= 0; i--) {
-      if (hookType === 'beforeEach') {
-        hooks.push(...suiteChain[i].beforeEach);
-      } else {
-        hooks.push(...suiteChain[i].beforeAll);
-      }
+      hooks.push(...suiteChain[i].beforeAll);
     }
   } else {
-    // For afterEach/afterAll: run child hooks first (use chain as-is)
+    // Run child suite hooks before parent suite hooks.
     for (const suiteInChain of suiteChain) {
-      if (hookType === 'afterEach') {
-        hooks.push(...suiteInChain.afterEach);
-      } else {
-        hooks.push(...suiteInChain.afterAll);
-      }
+      hooks.push(...suiteInChain.afterAll);
     }
   }
 
@@ -45,9 +57,19 @@ export const runHooks = async (
   hookType: HookType,
   context?: ActiveTestContext,
 ): Promise<void> => {
+  if (hookType === 'beforeAll' || hookType === 'afterAll') {
+    const hooks = collectSuiteHooks(suite, hookType);
+
+    for (const hook of hooks) {
+      await hook();
+    }
+
+    return;
+  }
+
   const hooks = collectInheritedHooks(suite, hookType);
 
   for (const hook of hooks) {
-    await hook(context);
+    await hook(context as ActiveTestContext);
   }
 };

tsconfig.json

@@ -62,6 +62,9 @@
     },
     {
       "path": "./packages/coverage-ios"
+    },
+    {
+      "path": "./website"
     }
   ]
 }