Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on November 2
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| failureDetails: [], | ||
| failureMessages: actualErrorMessage ? [actualErrorMessage] : [], | ||
| fullName: jestTestPath || test.testPath || '', | ||
| numPassingAsserts: test.errorMessage ? 1 : 0, |
There was a problem hiding this comment.
Bug: Test Result Logic Inverted
The numPassingAsserts logic is inverted. It currently sets numPassingAsserts to 1 when test.errorMessage exists (failed test) and 0 when it doesn't (passed test), which is the opposite of expected.
| harness.environment.restart(); | ||
| }); | ||
| } | ||
| isFirstTest = false; |
There was a problem hiding this comment.
Bug: Event Listener Timing Issue
A race condition exists where the 'ready' event listener is attached after harness.environment.restart() is called. If the environment becomes ready quickly, the event can be missed, causing the test runner to hang indefinitely. This wait also lacks timeout or error handling.
1 participant
Catching up with Jest, which has been under development for years, isn't easy (especially for a team with only a single developer). Therefore, it may make more sense to adopt Jest and use it as a CLI for Harness. This pull request implements a custom Jest runner based on Harness, capable of running tests on emulators, just like the Harness CLI.
With this approach, there's no need to maintain a separate CLI, and we can leverage the existing infrastructure for reports and other integrations. For example, I was able to set up test coverage support in just a few minutes, rather than hours.