fix(runtime): add Object.hasOwn polyfill for Hermes compatibility#50
Closed
bheemreddy-samsara wants to merge 1 commit intocallstackincubator:mainfrom
Closed
Conversation
Hermes (React Native's default JS engine) doesn't support Object.hasOwn (ES2022). This causes runtime errors when @vitest/expect v4.x initializes because it uses Object.hasOwn internally. Error without fix: ``` Object.hasOwn is not a function. (In 'Object.hasOwn(globalThis, MATCHERS_OBJECT)', 'Object.hasOwn' is undefined) ``` Add polyfill in runtime package that loads before @vitest/expect. Tracking: facebook/hermes#1875
|
@bheemreddy-samsara is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
Object.hasOwnpolyfill to the runtime package for Hermes compatibility.Hermes (React Native's default JS engine) doesn't support
Object.hasOwn(ES2022). This causes runtime errors when@vitest/expectv4.x initializes:Related Issue
Fixes #51
Context
The error originates from
@vitest/expect/dist/index.js:674:Since react-native-harness targets React Native (which uses Hermes by default) and depends on
@vitest/expectv4.x, the polyfill belongs in the harness runtime rather than requiring every consumer to add it.The polyfill is minimal and standards-compliant:
Testing
References