refactor: inject bridge server into Metro#88
Merged
Merged
Conversation
Unify harness traffic through Metro and deprecate the separate bridge port configuration.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
# Conflicts: # packages/bridge/src/server.ts # packages/bundler-metro/src/factory.ts # packages/bundler-metro/src/index.ts # packages/bundler-metro/src/types.ts # packages/jest/src/__tests__/harness.test.ts # packages/jest/src/harness.ts # packages/jest/src/setup.ts
Align Metro endpoint typing and test fixtures with the merged startup APIs so package typecheck passes again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change moves Harness bridge communication onto Metro so everything runs through a single dev server port instead of a separate bridge port.
It keeps the setup simpler and more predictable, reduces extra platform-specific port wiring, and preserves compatibility by keeping webSocketPort around as a deprecated config option for now.