feat(android): auto-switch dark theme#35
Conversation
|
mateusz1913
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Could I ask you on which devices (manufacturers) you tested your change?
I remember that some of the devices are problematic with dark mode (mainly some chinese e.g. Xiaomi) - I can test on one of older Xiaomis in next few days and will probably merge it
|
@mateusz1913 Tested on physical Xiaomi device and Pixel (emulated). |
|
Great! I'll give it a shot tomorrow |
mateusz1913
left a comment
There was a problem hiding this comment.
I gave it a shot and it's almost there 🎉, left 2 last comments
|
Done and tested, switching themes works just as before. |
ReactNativeLegalActivitywill automatically switch between dark/light theme based on Android device's theme. This feature is only available API 29+, on lower APIs,ReactNativeLegalActivitywill remain light.Perhaps
launchLicenseListScreenfunction could accept a bool "isDark" argument to make this programmatic.Tested API 29, 33, and 35.
See attached video for demonstration.
dark.webm