feat: extracted packages: license-kit CLI and @callstack/react-native-legal-shared#44
Merged
feat: extracted packages: license-kit CLI and @callstack/react-native-legal-shared#44
license-kit CLI and @callstack/react-native-legal-shared#44Conversation
🦋 Changeset detectedLatest commit: afb7f33 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mateusz1913
requested changes
Jun 9, 2025
…pl of presentation layer logic
…l build in react-native-legal
…files in react-native-legal
artus9033
force-pushed
the
feat/extracted-logic-and-cli
branch
from
e222341 to
b9d675e
Compare
mateusz1913
reviewed
Jun 13, 2025
Collaborator
mateusz1913
left a comment
mateusz1913
left a comment
There was a problem hiding this comment.
Thanks! I partially reviewed the PR and left a few comments. I'll do detail review during weekend or on monday
artus9033
changed the title
license-kit with @callstack/react-native-legal-shared common logic
artus9033
changed the title
license-kit with @callstack/react-native-legal-shared common logiclicense-kit CLI and @callstack/react-native-legal-shared
Collaborator
|
Thanks @mateusz1913 , your findings are really helpful! |
mateusz1913
reviewed
Jun 17, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This diff adds following changes:
license-kit- a CLI for listing licenses and verifying whether the project uses copyleft ones (e.g. GPL)@callstack/react-native-legal-shared- shared utils forreact-native-legalandlicense-kitreact-native-legalpackage ot use the common logic from@callstack/react-native-legal-shared@callstack/react-native-legal-sharedusing@rspress/plugin-typedocNew docs look:
Bulk of the work was done by @artus9033.