Merged
Conversation
🦋 Changeset detectedLatest commit: 06a09bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mateusz1913
reviewed
Jun 17, 2025
…ve & development dependencies
aaf3963 to
06a09bd
Compare
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a default argument
scanOptionsFactoryto@callstack/react-native-legal-shared'sscanPackage&scanDependenciesmethods. The default value of this argument has been set up for backwards compatibility reasons and is as follows:The introduced behaviour allows for passing a factory that will return configuration for a given
package.json, conditioning whether development & transitive dependencies should be included. This applies both to the root package and any scanned package. ThedevDependenciesoption also applies to transitive dependencies, i.e., if both flags aretrue, transitivedevDependencieswill also be included.Since the list of dependencies for the demo apps will be longer from now on (due to transitive dependencies), it would often cause a timeout due to long scrolling to reach the react-native list item. Due to that reason, this PR also introduces a modification to Maestro scenarios to initially fast-scroll (without assertions) the list to approx. half on Android to start scrolling from a position much closer to the target item.
The changes are non-breaking w.r.t. the library users.
This PR depends on #44 to be merged. To see just a comparison of the changes in this PR for the time #44 is not merged yet, please see the diff of feat/extracted-logic-and-cli...feat/shared-deps-scan-options.