Skip to content

test: more CLI tests#52

Merged
artus9033 merged 16 commits intomainfrom
test/more-cli-integration-tests
Jun 19, 2025
Merged

test: more CLI tests#52
artus9033 merged 16 commits intomainfrom
test/more-cli-integration-tests

Conversation

@artus9033
Copy link
Copy Markdown
Collaborator

@artus9033 artus9033 commented Jun 18, 2025

This PR introduces the following:

  • more integration tests to the license-kit CLI for the report command,
  • unit tests for utilities in the shared package
  • a CI workflow to run the unit tests
  • fix for an edge case in normalizeRepositoryUrl (git+ssh://git@github.com... URLs would not be converted properly so far - they would have a : separator instead of /)
  • clarifies a few details in the documentation of license-kit, corrects invalid default value & one typo in that documentation
  • extracts helpers from common.ts to separate yamlUtils.ts
  • adds badges for test-integration-node.yml & test-unit-shared.yml workflows to the root README.md

@artus9033 artus9033 requested a review from mateusz1913 June 18, 2025 23:07
@artus9033 artus9033 self-assigned this Jun 18, 2025
@artus9033 artus9033 added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 18, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 18, 2025

⚠️ No Changeset found

Latest commit: cd87699

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Collaborator

@mateusz1913 mateusz1913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🥳 left 2 comments to address before merging

Comment thread examples/node-example/__test__/global.d.ts
Comment thread .github/workflows/test-unit-shared.yml Outdated
@artus9033 artus9033 requested a review from mateusz1913 June 19, 2025 10:08
Copy link
Copy Markdown
Collaborator

@mateusz1913 mateusz1913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Two small things to change and let's ship it!

Comment thread README.md Outdated
Comment thread .github/workflows/test-unit-shared.yml Outdated
@artus9033
Copy link
Copy Markdown
Collaborator Author

Thanks @mateusz1913!

@artus9033 artus9033 requested a review from mateusz1913 June 19, 2025 10:16
Copy link
Copy Markdown
Collaborator

@mateusz1913 mateusz1913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@artus9033 artus9033 merged commit 65e5ff7 into main Jun 19, 2025
14 of 19 checks passed
@artus9033 artus9033 deleted the test/more-cli-integration-tests branch June 19, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants