Conversation
|
mateusz1913
reviewed
Jun 19, 2025
Collaborator
mateusz1913
left a comment
There was a problem hiding this comment.
Great job 🥳 left 2 comments to address before merging
mateusz1913
approved these changes
Jun 19, 2025
Collaborator
mateusz1913
left a comment
There was a problem hiding this comment.
Great job! Two small things to change and let's ship it!
Collaborator
Author
|
Thanks @mateusz1913! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following:
license-kitCLI for thereportcommand,normalizeRepositoryUrl(git+ssh://git@github.com...URLs would not be converted properly so far - they would have a:separator instead of/)license-kit, corrects invalid default value & one typo in that documentationcommon.tsto separateyamlUtils.tstest-integration-node.yml&test-unit-shared.ymlworkflows to the rootREADME.md