Skip to content

Commit 169c2dd

Browse files
committed
fix: declare cmake-rn dependency in weak-node-api
weak-node-api's `prebuild:build` script invokes the `cmake-rn` CLI, but the package never declared cmake-rn. Under npm's hoisting every workspace bin was linked into the root node_modules/.bin, so `cmake-rn` was always on PATH. pnpm only links a package's *declared* dependencies' bins, so on CI the bootstrap failed with `cmake-rn: not found` (a phantom bin dependency that only surfaces when the native prebuild runs). Declare `cmake-rn` as a devDependency (workspace:*) so pnpm links its bin into weak-node-api/node_modules/.bin. This introduces a benign dev-time cycle (cmake-rn imports weak-node-api's JS for prebuild paths; weak-node-api's build uses the cmake-rn CLI) which pnpm reports as a warning and handles fine; the topological bootstrap still sequences weak-node-api before its consumers. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DnwodAoNbqPec77191HVXn
1 parent a1adfea commit 169c2dd

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

packages/weak-node-api/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@
6868
"node-api-headers": "^1.5.0"
6969
},
7070
"devDependencies": {
71+
"cmake-rn": "workspace:*",
7172
"zod": "^4.1.11"
7273
}
7374
}

pnpm-lock.yaml

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)