Phase 2: bump Node-API to v10, drop engine/runtime split

All Node-API symbols are now sourced from Hermes' hermesNapi, so the old
engine (js_native_api → libhermes.so) / runtime (node_api →
libnode-api-host.so) distinction and the hand-maintained
IMPLEMENTED_RUNTIME_FUNCTIONS allow-list are obsolete.

- weak-node-api: getNodeApiFunctions defaults to v10 and no longer computes
  the dead `kind`/`libraryPath` fields; CMake compiles the generated
  weak_node_api.cpp at NAPI_VERSION=10 (145 → 155 symbols, adding the v9/v10
  node_api_* surface).
- generate-injector.mts: bind every symbol (no filter) and emit
  `#include <Versions.hpp>` first so the injector TU also compiles at v10.
- Versions.hpp: guarded bump to NAPI_VERSION 10.

Regenerated (gitignored) WeakNodeApiInjector.cpp + weak-node-api/generated
now expose all 155 symbols incl. TSFN and napi_make_callback. Verified:
build, prettier, lint, workspace unit tests, and the weak-node-api native
build + ctest all pass. iOS e2e pending (rides the cold re-vendor).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: kraenhansen

packages/host/cpp/Versions.hpp

@@ -1,3 +1,7 @@
 #pragma once
 
-#define NAPI_VERSION 8
+// Must be defined before any <node_api.h> include so the header exposes the
+// full v10 surface (js_native_api.h otherwise defaults this to 8).
+#ifndef NAPI_VERSION
+#define NAPI_VERSION 10
+#endif

packages/host/scripts/generate-injector.mts

@@ -6,35 +6,22 @@ import { type FunctionDecl, getNodeApiFunctions } from "weak-node-api";
 
 export const CPP_SOURCE_PATH = path.join(import.meta.dirname, "../cpp");
 
-// TODO: Remove when all runtime Node API functions are implemented
-const IMPLEMENTED_RUNTIME_FUNCTIONS = [
-  "napi_create_buffer",
-  "napi_create_buffer_copy",
-  "napi_is_buffer",
-  "napi_get_buffer_info",
-  "napi_create_external_buffer",
-  "napi_create_async_work",
-  "napi_queue_async_work",
-  "napi_delete_async_work",
-  "napi_cancel_async_work",
-  "napi_fatal_error",
-  "napi_get_node_version",
-  "napi_get_version",
-];
-
 /**
  * Generates source code which injects the Node API functions from the host.
  */
 export function generateSource(functions: FunctionDecl[]) {
   return `
     // This file is generated by react-native-node-api
+    // Versions.hpp must come first so <node_api.h> exposes the full v10 surface.
+    #include <Versions.hpp>
+
     #include <dlfcn.h>
     #include <weak_node_api.hpp>
 
     #include <Logger.hpp>
     #include <RuntimeNodeApi.hpp>
     #include <RuntimeNodeApiAsync.hpp>
-    
+
     #if defined(__APPLE__)
     #define WEAK_NODE_API_LIBRARY_NAME "@rpath/weak-node-api.framework/weak-node-api"
     #elif defined(__ANDROID__)
@@ -61,13 +48,7 @@ export function generateSource(functions: FunctionDecl[]) {
 
     log_debug("Injecting NodeApiHost");
     inject_weak_node_api_host(NodeApiHost {
-      ${functions
-        .filter(
-          ({ kind, name }) =>
-            kind === "engine" || IMPLEMENTED_RUNTIME_FUNCTIONS.includes(name),
-        )
-        .flatMap(({ name }) => `.${name} = ${name},`)
-        .join("\n")}
+      ${functions.flatMap(({ name }) => `.${name} = ${name},`).join("\n")}
       });
     }
     } // namespace callstack::react_native_node_api

packages/weak-node-api/CMakeLists.txt

@@ -56,7 +56,7 @@ endif()
 
 # C++20 is needed to use designated initializers
 target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_20)
-target_compile_definitions(${PROJECT_NAME} PRIVATE NAPI_VERSION=8)
+target_compile_definitions(${PROJECT_NAME} PRIVATE NAPI_VERSION=10)
 
 target_compile_options(${PROJECT_NAME} PRIVATE
   $<$<CXX_COMPILER_ID:MSVC>:/W4 /WX>

packages/weak-node-api/src/node-api-functions.ts

@@ -78,24 +78,25 @@ export function getNodeApiHeaderAST(version: NodeApiVersion) {
 
 export type FunctionDecl = {
   name: string;
-  kind: "engine" | "runtime";
   returnType: string;
   noReturn: boolean;
   argumentTypes: string[];
-  libraryPath: string;
   fallbackReturnStatement: string;
 };
 
-export function getNodeApiFunctions(version: NodeApiVersion = "v8") {
+export function getNodeApiFunctions(version: NodeApiVersion = "v10") {
   const root = getNodeApiHeaderAST(version);
   assert.equal(root.kind, "TranslationUnitDecl");
   assert(Array.isArray(root.inner));
   const foundSymbols = new Set();
 
+  // Both interfaces are now sourced from the same host (hermesNapi provides
+  // every symbol), so there is no engine/runtime distinction to preserve.
   const symbolsPerInterface = nodeApiHeaders.symbols[version];
-  const engineSymbols = new Set(symbolsPerInterface.js_native_api_symbols);
-  const runtimeSymbols = new Set(symbolsPerInterface.node_api_symbols);
-  const allSymbols = new Set([...engineSymbols, ...runtimeSymbols]);
+  const allSymbols = new Set([
+    ...symbolsPerInterface.js_native_api_symbols,
+    ...symbolsPerInterface.node_api_symbols,
+  ]);
 
   const nodeApiFunctions: FunctionDecl[] = [];
 
@@ -131,14 +132,9 @@ export function getNodeApiFunctions(version: NodeApiVersion = "v8") {
         name,
         returnType,
         noReturn: node.type.qualType.includes("__attribute__((noreturn))"),
-        kind: engineSymbols.has(name) ? "engine" : "runtime",
         argumentTypes: argumentTypes
           .split(",")
           .map((arg) => arg.trim().replace("_Bool", "bool")),
-        // Defer to the right library
-        libraryPath: engineSymbols.has(name)
-          ? "libhermes.so"
-          : "libnode-api-host.so",
         fallbackReturnStatement:
           returnType === "void"
             ? "abort();"