add safeParse for configuration node-api

Author: owl352

packages/host/src/node/path-utils.test.ts

@@ -541,6 +541,50 @@ describe("findNodeApiModulePathsByDependency", () => {
     });
   });
 
+  it("should find Node-API paths by dependency in root package.json with bad configuration (excluding certain packages)", async (context) => {
+    const packagesNames = ["lib-a", "lib-b", "lib-c", "lib-d", "lib-e"];
+    const tempDir = setupTempDirectory(context, {
+      "app/package.json": JSON.stringify({
+        name: "app",
+        dependencies: Object.fromEntries(
+          packagesNames
+            .slice(0, 2)
+            .map((packageName) => [packageName, "^1.0.0"]),
+        ),
+        reactNativeNodeApi: {
+          scan: "lib-e",
+        },
+      }),
+      ...Object.fromEntries(
+        packagesNames.map((packageName) => [
+          `app/node_modules/${packageName}`,
+          {
+            "package.json": JSON.stringify({
+              name: packageName,
+              main: "index.js",
+            }),
+            "index.js": "",
+            "addon.apple.node/react-native-node-api-module": "",
+          },
+        ]),
+      ),
+    });
+
+    // shouldn't drop error
+    const result = await findNodeApiModulePathsByDependency({
+      fromPath: path.join(tempDir, "app"),
+      platform: "apple",
+      includeSelf: false,
+      excludePackages: ["lib-a"],
+    });
+    assert.deepEqual(result, {
+      "lib-b": {
+        path: path.join(tempDir, "app/node_modules/lib-b"),
+        modulePaths: ["addon.apple.node"],
+      },
+    });
+  });
+
   it("should find Node-API paths by dependency in root package.json configuration with incorrect dependency configuration (excluding certain packages)", async (context) => {
     const packagesNames = ["lib-a", "lib-b", "lib-c", "lib-d"];
     const tempDir = setupTempDirectory(context, {
@@ -706,7 +750,7 @@ describe("findNodeApiModulePathsByDependency", () => {
         packagesNames.slice(1).map((packageName, i) => {
           // if even then i-1
           // if not even then i+1
-          const dependencyIndex = i + ((i % 2) * 2 - 1)
+          const dependencyIndex = i + ((i % 2) * 2 - 1);
 
           return [
             `app/node_modules/${packageName}`,

packages/host/src/node/path-utils.ts

@@ -321,6 +321,21 @@ export type PackageJsonDependencies = zod.infer<
 type PackageJsonWithNodeApi = PackageJsonDependencies &
   ReactNativeNodeAPIConfiguration;
 
+export function parseReactNativeNodeAPIConfigurationSchema(
+  packageJson: PackageJsonWithNodeApi,
+): ReactNativeNodeAPIConfiguration {
+  const parsed = ReactNativeNodeAPIConfigurationSchema.safeParse(packageJson);
+
+  if (!parsed.success) {
+    console.warn("Invalid reactNativeNodeApi configuration");
+    console.warn(JSON.stringify(packageJson));
+    console.warn(parsed.error.message);
+    return {};
+  }
+
+  return parsed.data;
+}
+
 export function findPackageConfigurationByPath(
   fromPath: string,
 ): ReactNativeNodeAPIConfiguration {
@@ -331,7 +346,7 @@ export function findPackageConfigurationByPath(
     cwd: packageRoot,
   });
 
-  return ReactNativeNodeAPIConfigurationSchema.parse(packageJson);
+  return parseReactNativeNodeAPIConfigurationSchema(packageJson);
 }
 
 /**
@@ -356,7 +371,7 @@ export function findPackageDependencyPaths(
   const { dependencies = {} } =
     PackageJsonDependenciesSchema.parse(packageJson);
   const { reactNativeNodeApi } =
-    ReactNativeNodeAPIConfigurationSchema.parse(packageJson);
+    parseReactNativeNodeAPIConfigurationSchema(packageJson);
 
   const initialDeps = Object.keys(dependencies).concat(
     reactNativeNodeApi?.scan?.dependencies ?? [],