-
Notifications
You must be signed in to change notification settings - Fork 7
Apple link without cocoapods #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 12 commits
9532c9f
3d3f318
fedc119
0cbe2ac
1bb9529
b382de8
987437b
218cfb2
7adb43e
6687b87
9ed4b21
68e45f0
0b01fd5
2c5c964
4be7486
c7bd14a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "react-native-node-api": minor | ||
| --- | ||
|
|
||
| Modify Xcode project to add a build phase to the main project app to link Node-API frameworks directly |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| unless defined?(@exit_hooks_installed) | ||
| # Setting a flag to avoid running this command on every require | ||
| @exit_hooks_installed = true | ||
|
|
||
| NODE_PATH ||= `which node`.strip | ||
|
||
| CLI_COMMAND ||= "'#{NODE_PATH}' '#{File.join(__dir__, "../dist/node/cli/run.js")}'" | ||
| PATCH_XCODE_PROJECT_COMMAND ||= "#{CLI_COMMAND} patch-xcode-project '#{Pod::Config.instance.installation_root}'" | ||
|
|
||
| # Using an at_exit hook to ensure the command is executed after the pod install is complete | ||
| at_exit do | ||
| system(PATCH_XCODE_PROJECT_COMMAND) or raise "Failed to patch the Xcode project" | ||
| end | ||
| end | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one of the most important changes of the PR - we no longer have to reference the addon xcframeworks from our podspec.