Skip to content

fix(plugin-metro): support Windows dynamic imports#719

Merged
thymikee merged 1 commit into
callstackincubator:mainfrom
jbroma:fix/plugin-metro-windows-import-paths
Jul 10, 2026
Merged

fix(plugin-metro): support Windows dynamic imports#719
thymikee merged 1 commit into
callstackincubator:mainfrom
jbroma:fix/plugin-metro-windows-import-paths

Conversation

@jbroma

@jbroma jbroma commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Convert resolved Metro dependency paths to file URLs before passing them to dynamic import
  • Fix Windows absolute paths like C:... being treated as unsupported ESM specifiers
  • Add a patch changeset for @rock-js/plugin-metro

Verification

  • pnpm --filter @rock-js/plugin-metro... build
  • pnpm exec prettier --check .changeset/warm-windows-imports.md packages/plugin-metro/src/lib/getReactNativeDeps.ts packages/plugin-metro/src/lib/start/loadMetroConfig.ts
  • pnpm exec eslint packages/plugin-metro/src/lib/getReactNativeDeps.ts packages/plugin-metro/src/lib/start/loadMetroConfig.ts

Downstream validation: verified the equivalent patch in module-federation/core with the Metro Android host running on Windows: host, remote, and nested remote rendered successfully in the emulator.

@vercel

vercel Bot commented Jul 10, 2026

Copy link
Copy Markdown

@jbroma is attempting to deploy a commit to the Callstack Team on Vercel.

A member of the Team first needs to authorize it.

@jbroma
jbroma requested a review from thymikee July 10, 2026 14:16
@thymikee
thymikee merged commit 59df41c into callstackincubator:main Jul 10, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants