Skip to content

fix(network-activity-plugin): race condition when reloading the app#235

Merged
V3RON merged 1 commit intomainfrom
fix/network-activity-reconnect-race
Apr 29, 2026
Merged

fix(network-activity-plugin): race condition when reloading the app#235
V3RON merged 1 commit intomainfrom
fix/network-activity-reconnect-race

Conversation

@V3RON
Copy link
Copy Markdown
Contributor

@V3RON V3RON commented Apr 29, 2026

Summary

  • Adds a recording-state event sent by the React Native side to the DevTools UI on every new connection, broadcasting the current recording state.
  • The DevTools UI listens for this event and re-syncs its recording toggle by sending network-enable or network-disable if the states diverge.
  • This fixes a race condition where reloading the app could leave the UI and the native side out of sync (e.g. UI shows recording enabled but native has reset to disabled).

Test plan

  • Start the app with network recording enabled, reload the app, and verify the DevTools UI stays in sync with the native recording state.
  • Toggle recording off, reload the app, and confirm the UI reflects the disabled state.
  • Verify no regressions in normal network recording start/stop flow.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
rozenite Skipped Skipped Apr 29, 2026 10:46am

Request Review

@V3RON V3RON merged commit 301abfe into main Apr 29, 2026
6 checks passed
@V3RON V3RON deleted the fix/network-activity-reconnect-race branch April 29, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant