Commit 8cedb47
fix: activity name being ignored when starting live activity (#116)
Fixes #115
`startLiveActivity` was sending `activityId` as the bridge key, but
`StartVoltraOptions` declares `@Field activityName`. so the value was
silently dropped — activities always got a random UUID instead
## Changes
- Renamed `activityId` to `activityName` in the TS bridge types and call
sites so the key matches Swift.
- Fixed the unit test that was asserting the wrong key.
## Test plan
- [x] `npm test` — unit tests pass (including corrected `activityName
preserved` test)
- [x] `npm run build` — type checking
---------
Co-authored-by: Szymon Chmal <szymon@chmal.it>1 parent 2661e11 commit 8cedb47
File tree
6 files changed
+10
-5
lines changed- .changeset
- packages
- ios-client/src
- live-activity
- voltra/src
- live-activity
- __tests__
6 files changed
+10
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
188 | | - | |
| 188 | + | |
189 | 189 | | |
190 | 190 | | |
191 | 191 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
114 | | - | |
| 114 | + | |
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
280 | 280 | | |
281 | 281 | | |
282 | 282 | | |
283 | | - | |
| 283 | + | |
284 | 284 | | |
285 | 285 | | |
286 | 286 | | |
| |||
0 commit comments