Skip to content

fix: activity name being ignored when starting live activity#116

Merged
V3RON merged 3 commits intocallstackincubator:mainfrom
rshallam:fix/activity-name-binding
Apr 13, 2026
Merged

fix: activity name being ignored when starting live activity#116
V3RON merged 3 commits intocallstackincubator:mainfrom
rshallam:fix/activity-name-binding

Conversation

@rshallam
Copy link
Copy Markdown
Contributor

@rshallam rshallam commented Mar 24, 2026

Fixes #115

startLiveActivity was sending activityId as the bridge key, but StartVoltraOptions declares @Field activityName. so the value was silently dropped — activities always got a random UUID instead

Changes

  • Renamed activityId to activityName in the TS bridge types and call sites so the key matches Swift.
  • Fixed the unit test that was asserting the wrong key.

Test plan

  • npm test — unit tests pass (including corrected activityName preserved test)
  • npm run build — type checking

@V3RON
Copy link
Copy Markdown
Contributor

V3RON commented Apr 13, 2026

Thank you! ❤️

@V3RON V3RON merged commit 8cedb47 into callstackincubator:main Apr 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

activity name doesn't bind to live activity

2 participants